Issue 10444010: Revert 138554 - Prevent zero-length items from being appended to a blob.

Issue 10444010: Revert 138554 - Prevent zero-length items from being appended to a blob. (Closed)

Created:
8 years, 7 months ago by danakj

Modified:
8 years, 7 months ago

Reviewers:
ericu

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, kinuko+watch, darin-cc_chromium.org, jochen+watch-content_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 138554 - Prevent zero-length items from being appended to a blob. BUG=128266 TEST=as in the bug Review URL: https://chromiumcodereview.appspot.com/10386183 TBR=ericu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138791

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -65 lines)			Patch
M	content/browser/fileapi/fileapi_message_filter.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/fileapi/fileapi_message_filter.cc	View	3 chunks	+0 lines, -14 lines	0 comments	Download
M	content/common/fileapi/webblobregistry_impl.cc	View	3 chunks	+7 lines, -11 lines	0 comments	Download
M	webkit/blob/blob_data.h	View	3 chunks	+25 lines, -5 lines	0 comments	Download
M	webkit/blob/blob_data.cc	View	2 chunks	+1 line, -32 lines	0 comments	Download
M	webkit/blob/blob_storage_controller.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/fileapi/file_system_operation_write_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

danakj

Failures on blob webkit tests after this change: http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28deps%29/builds/14869

8 years, 7 months ago (2012-05-24 14:43:39 UTC) #2

ericu

Dana: I see a revert, and a revert-revert, that happened while I was out. Is ...

8 years, 6 months ago (2012-05-29 20:58:10 UTC) #3

danakj

Hi Eric, Yep. It seemed like your change caused test failures, but the revert did ...

8 years, 6 months ago (2012-05-29 21:21:28 UTC) #4

ericu

8 years, 6 months ago (2012-05-29 21:23:31 UTC) #5

OK, thanks!

There are still some problems, but they're debug-only, and I'm working
on them now.  Just wanted to make sure I knew about all the issues.

On Tue, May 29, 2012 at 2:21 PM, Dana Jansens <danakj@chromium.org> wrote:
> Hi Eric,
>
> Yep. It seemed like your change caused test failures, but the revert did not
> fix, so I undid it. Anyhow, the gardener later managed to sort out the issue
> it seems :)
>
> Cheers,
> Dana
>
> On Tue, May 29, 2012 at 4:57 PM, Eric Uhrhane <ericu@chromium.org> wrote:
>>
>> Dana:
>>
>>        I see a revert, and a revert-revert, that happened while I was out.
>> Is everything OK now?
>>
>>                Eric
>>
>> On Thu, May 24, 2012 at 7:43 AM,  <danakj@chromium.org> wrote:
>> > Failures on blob webkit tests after this change:
>> >
>> >
>> >
http://build.chromium.org/p/chromium.webkit/builders/Webkit%20Mac10.6%20%28de...
>> >
>> > https://chromiumcodereview.appspot.com/10444010/
>
>

Expand Messages | Collapse Messages