Add presubmit check for unversioned PPB interface macros in C++ wrappers.

Add presubmit check for unversioned PPB interface macros in C++ wrappers.

BUG=107398
TEST=Presubmit fails if a C++ wrapper implementation is modified and it uses unversioned PPB interface macro, succeeds otherwise.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140065

[Wez, 2012-05-31 22:02:21]

dmichael: PTAL - a rough check for use of unversioned PPB name macros based on
their naming convention.  I've applied the check to the stable interface
wrappers and to trusted since the wrappers there already pass (once the pp::View
CL I sent you earlier is in).

brettw, noelallen: FYI

[dmichael (off chromium), 2012-06-01 14:28:34]

Thanks for doing this!

A couple of r.e. nits, o/w lgtm

http://codereview.chromium.org/10443119/diff/1/ppapi/PRESUBMIT.py
File ppapi/PRESUBMIT.py (right):

http://codereview.chromium.org/10443119/diff/1/ppapi/PRESUBMIT.py#newcode95
ppapi/PRESUBMIT.py:95: RE_UNVERSIONED_PPB = re.compile(r'\WPPB_\w+_INTERFACE\W')
I think technically "\b" would be more appropriate than "\W", though it
shouldn't matter much in practice. You also probably want "[\w\d_]+" in the
middle instead of "\w+".

[Wez, 2012-06-01 18:32:16]

http://codereview.chromium.org/10443119/diff/1/ppapi/PRESUBMIT.py
File ppapi/PRESUBMIT.py (right):

http://codereview.chromium.org/10443119/diff/1/ppapi/PRESUBMIT.py#newcode95
ppapi/PRESUBMIT.py:95: RE_UNVERSIONED_PPB = re.compile(r'\WPPB_\w+_INTERFACE\W')
On 2012/06/01 14:28:34, dmichael wrote:
> I think technically "\b" would be more appropriate than "\W", though it
> shouldn't matter much in practice. You also probably want "[\w\d_]+" in the
> middle instead of "\w+".

Done re "\W" -> "\b".

"\w" matches [a-zA-Z0-9_] according to the Python docs, so I think it's correct
here.

[dmichael (off chromium), 2012-06-01 18:44:48]

On Fri, Jun 1, 2012 at 12:32 PM, <wez@chromium.org> wrote:

>
>
http://codereview.chromium.**org/10443119/diff/1/ppapi/**PRESUBMIT.py<http://...
> File ppapi/PRESUBMIT.py (right):
>
> http://codereview.chromium.**org/10443119/diff/1/ppapi/**
>
PRESUBMIT.py#newcode95<http://codereview.chromium.org/10443119/diff/1/ppapi/PRESUBMIT.py#newcode95>
> ppapi/PRESUBMIT.py:95: RE_UNVERSIONED_PPB =
> re.compile(r'\WPPB_\w+_**INTERFACE\W')
> On 2012/06/01 14:28:34, dmichael wrote:
>
>> I think technically "\b" would be more appropriate than "\W", though
>>
> it
>
>> shouldn't matter much in practice. You also probably want "[\w\d_]+"
>>
> in the
>
>> middle instead of "\w+".
>>
>
> Done re "\W" -> "\b".
>
> "\w" matches [a-zA-Z0-9_] according to the Python docs, so I think it's
> correct here.
>
d'oh. I was thinking it was [a-zA-Z]. Thanks :-) lgtm


>
>
http://codereview.chromium.**org/10443119/<http://codereview.chromium.org/104...
>