Add presubmit check for unversioned PPB interface macros in C++ wrappers.

ppapi/PRESUBMIT.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import os
 import re
 import sys
 import subprocess
 
 
@@ skipping 73 matching lines @@
     filepath = os.path.join('..', filename)
     if RE_TODO.search(open(filepath, 'rb').read()):
       todo.append(filename)
 
   if todo:
     return [output_api.PresubmitError(
         'TODOs found in stable public PPAPI files:',
         long_text='\n'.join(todo))]
   return []
 
+# Verify that no CPP wrappers use un-versioned PPB interface name macros.
+RE_UNVERSIONED_PPB = re.compile(r'\bPPB_\w+_INTERFACE\b')
+def CheckUnversionedPPB(input_api, output_api):
+  files = input_api.LocalPaths()
+  todo = []
+
+  for filename in files:
+    name, ext = os.path.splitext(filename)
+    name_parts = name.split(os.sep)
+
+    # Only check C++ sources.
+    if ext not in ['.cc']:
+      continue
+
+    # Only examine the public plugin facing ppapi/cpp directory.
+    if name_parts[0:2] != ['ppapi', 'cpp']:
+      continue
+
+    # Only examine public stable and trusted interfaces.
+    if name_parts[2] in ['dev', 'private']:
+      continue
+
+    filepath = os.path.join('..', filename)
+    if RE_UNVERSIONED_PPB.search(open(filepath, 'rb').read()):
+      todo.append(filename)
+
+  if todo:
+    return [output_api.PresubmitError(
+        'Unversioned PPB interface references found in PPAPI C++ wrappers:',
+        long_text='\n'.join(todo))]
+  return []
 
 def CheckChange(input_api, output_api):
   results = []
 
   results.extend(CheckSrpcChange(input_api, output_api))
 
   results.extend(RunUnittests(input_api, output_api))
 
   results.extend(CheckTODO(input_api, output_api))
+
+  results.extend(CheckUnversionedPPB(input_api, output_api))
+
   # Verify all modified *.idl have a matching *.h
   files = input_api.LocalPaths()
   h_files = []
   idl_files = []
 
   # Find all relevant .h and .idl files.
   for filename in files:
     name, ext = os.path.splitext(filename)
     name_parts = name.split(os.sep)
     if name_parts[0:2] == ['ppapi', 'c'] and ext == '.h':
@@ skipping 76 matching lines @@
 
   return results
 
 
 def CheckChangeOnUpload(input_api, output_api):
   return CheckChange(input_api, output_api)
 
 
 def CheckChangeOnCommit(input_api, output_api):
   return CheckChange(input_api, output_api)