Issue 10443091: Make BrowserMainParts have an empty implementation to make embedding easier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10443091: Make BrowserMainParts have an empty implementation to make embedding easier. (Closed)

Created:
8 years, 6 months ago by jam

Modified:
8 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews, cbentzel+watch_chromium.org, sadrul, jochen+watch-content_chromium.org, ben+watch_chromium.org, grt+watch_chromium.org, amit, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, tfarina, robertshield

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make BrowserMainParts have an empty implementation to make embedding easier. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=139626

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -115 lines)			Patch
M	chrome/browser/chrome_browser_main_extra_parts.h	View	1 chunk	+12 lines, -16 lines	0 comments	Download
D	chrome/browser/chrome_browser_main_extra_parts.cc	View	1 chunk	+0 lines, -44 lines	0 comments	Download
M	chrome/browser/ui/aura/chrome_browser_main_extra_parts_aura.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/chrome_browser_main_extra_parts_gtk.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/ash/chrome_browser_main_extra_parts_ash.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/chrome_browser_main_extra_parts_views.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome_frame/test/net/fake_external_tab.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/content_browser.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	content/public/browser/browser_main_parts.h	View	2 chunks	+10 lines, -10 lines	0 comments	Download
A	content/public/browser/browser_main_parts.cc	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	content/shell/shell_browser_main_parts.h	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	content/shell/shell_browser_main_parts.cc	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	ui/views/examples/content_client/examples_browser_main_parts.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	ui/views/examples/content_client/examples_browser_main_parts.cc	View	1 chunk	+1 line, -11 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages