Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1510)

Unified Diff: content/public/browser/browser_main_parts.h

Issue 10443091: Make BrowserMainParts have an empty implementation to make embedding easier. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_browser.gypi ('k') | content/public/browser/browser_main_parts.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/browser_main_parts.h
===================================================================
--- content/public/browser/browser_main_parts.h (revision 139582)
+++ content/public/browser/browser_main_parts.h (working copy)
@@ -54,16 +54,16 @@
BrowserMainParts() {}
virtual ~BrowserMainParts() {}
- virtual void PreEarlyInitialization() = 0;
+ virtual void PreEarlyInitialization() {}
- virtual void PostEarlyInitialization() = 0;
+ virtual void PostEarlyInitialization() {}
- virtual void PreMainMessageLoopStart() = 0;
+ virtual void PreMainMessageLoopStart() {}
- virtual void PostMainMessageLoopStart() = 0;
+ virtual void PostMainMessageLoopStart() {}
// Allows an embedder to do any extra toolkit initialization.
- virtual void ToolkitInitialized() = 0;
+ virtual void ToolkitInitialized() {}
// Called just before any child threads owned by the content
// framework are created.
@@ -71,24 +71,24 @@
// The main message loop has been started at this point (but has not
// been run), and the toolkit has been initialized. Returns the error code
// (or 0 if no error).
- virtual int PreCreateThreads() = 0;
+ virtual int PreCreateThreads();
// This is called just before the main message loop is run. The
// various browser threads have all been created at this point
- virtual void PreMainMessageLoopRun() = 0;
+ virtual void PreMainMessageLoopRun() {}
// Returns true if the message loop was run, false otherwise.
// If this returns false, the default implementation will be run.
// May set |result_code|, which will be returned by |BrowserMain()|.
- virtual bool MainMessageLoopRun(int* result_code) = 0;
+ virtual bool MainMessageLoopRun(int* result_code);
// This happens after the main message loop has stopped, but before
// threads are stopped.
- virtual void PostMainMessageLoopRun() = 0;
+ virtual void PostMainMessageLoopRun() {}
// Called as the very last part of shutdown, after threads have been
// stopped and destroyed.
- virtual void PostDestroyThreads() = 0;
+ virtual void PostDestroyThreads() {}
};
} // namespace content
« no previous file with comments | « content/content_browser.gypi ('k') | content/public/browser/browser_main_parts.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698