Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7797)

Unified Diff: chrome/browser/ui/extensions/shell_window.h

Issue 10443075: Coverity PASS_BY_VALUE fix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/shell_window.h
diff --git a/chrome/browser/ui/extensions/shell_window.h b/chrome/browser/ui/extensions/shell_window.h
index 5b051edab61a60aac5a8a029ec288ce8261ca521..b7f8f8117c0c7b38070c3c4290dcbf45ba406c83 100644
--- a/chrome/browser/ui/extensions/shell_window.h
+++ b/chrome/browser/ui/extensions/shell_window.h
@@ -55,7 +55,7 @@ class ShellWindow : public content::NotificationObserver,
static ShellWindow* Create(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const CreateParams params);
+ const CreateParams& params);
const SessionID& session_id() const { return session_id_; }
const extensions::Extension* extension() const { return extension_; }
@@ -89,7 +89,7 @@ class ShellWindow : public content::NotificationObserver,
static ShellWindow* CreateImpl(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- CreateParams params);
+ const CreateParams& params);
// content::WebContentsObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
« no previous file with comments | « chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm ('k') | chrome/browser/ui/extensions/shell_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698