Silent mouse lock after unlock by target

content/public/browser/web_contents_delegate.h

Index: content/public/browser/web_contents_delegate.h
diff --git a/content/public/browser/web_contents_delegate.h b/content/public/browser/web_contents_delegate.h
index a3e070bb86eca1205d02b5c8e6a095ac1c012a3c..8fbff0f2cb8539e94a792f8b8018ee2bd0543dba 100644
--- a/content/public/browser/web_contents_delegate.h
+++ b/content/public/browser/web_contents_delegate.h
@@ -392,7 +392,9 @@ class CONTENT_EXPORT WebContentsDelegate {
   // GotResponseToLockMouseRequest() will be called on the requesting tab
   // contents.
   virtual void RequestToLockMouse(WebContents* web_contents,
-                                  bool user_gesture) {}
+                                  bool /* user_gesture */,

[sky, 2012/05/30 22:48:27]

Don't comment out parameters like this (the rest of the class doesn't do this).

Two boolean parameters like this becomes a bit unreadable. Did you consider a
bitmask?

[dmurph, 2012/05/31 21:13:49]

We tried enums, we considered bitmasks, and we concluded that booleans maximize
readability for this case.

Done.

On 2012/05/30 22:48:27, sky wrote:

+                                  bool /* last_unlocked_by_target */) {
+  }
 
   // Notification that the page has lost the mouse lock.
   virtual void LostMouseLock() {}