Silent mouse lock after unlock by target

content/public/browser/web_contents_delegate.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_
 #pragma once
 
 #include <set>
 #include <string>
@@ skipping 374 matching lines @@
   // Notification message from HTML UI.
   virtual void WebUISend(WebContents* web_contents,
                          const GURL& source_url,
                          const std::string& name,
                          const base::ListValue& args) {}
 
   // Requests to lock the mouse. Once the request is approved or rejected,
   // GotResponseToLockMouseRequest() will be called on the requesting tab
   // contents.
   virtual void RequestToLockMouse(WebContents* web_contents,
-                                  bool user_gesture) {}
+                                  bool /* user_gesture */,

[sky, 2012/05/30 22:48:27]

Don't comment out parameters like this (the rest of the class doesn't do this).

Two boolean parameters like this becomes a bit unreadable. Did you consider a
bitmask?

[dmurph, 2012/05/31 21:13:49]

We tried enums, we considered bitmasks, and we concluded that booleans maximize
readability for this case.

Done.

On 2012/05/30 22:48:27, sky wrote:

+                                  bool /* last_unlocked_by_target */) {
+  }
 
   // Notification that the page has lost the mouse lock.
   virtual void LostMouseLock() {}
 
  protected:
   virtual ~WebContentsDelegate();
 
  private:
   friend class ::WebContentsImpl;
 
   // Called when |this| becomes the WebContentsDelegate for |source|.
   void Attach(WebContents* source);
 
   // Called when |this| is no longer the WebContentsDelegate for |source|.
   void Detach(WebContents* source);
 
   // The WebContents that this is currently a delegate for.
   std::set<WebContents*> attached_contents_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_DELEGATE_H_