Move common notification layout to base class

Move common notification layout to base class
Also, don't show tray icons for SMS or locale change

BUG=124269
TEST=Set about::flags --ash-notify. Notification views should look consistent. SMS and locale change notifiations should not have visible tray icons.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138826

[stevenjb, 2012-05-24 00:59:17]

Some cleanup to make the system tray notification appearance and behavior
consistent now that they are all in.
(The changes in locale_change_guard.cc should have already made it in but seem
to have got lost when the locale changes were committed).

This is ready for review.

[stevenjb, 2012-05-24 01:01:36]

+jennyz FYI (this includes some changes to the power notification layout). These
are the last changes I hope to make to that, except for possibly updating the
icon images.

[sadrul, 2012-05-24 04:12:50]

LGTM with the some nits

http://codereview.chromium.org/10443004/diff/2001/ash/system/locale/tray_loca...
File ash/system/locale/tray_locale.h (right):

http://codereview.chromium.org/10443004/diff/2001/ash/system/locale/tray_loca...
ash/system/locale/tray_locale.h:29: virtual bool GetInitialVisibility()
OVERRIDE;
This isn't necessary anymore.

http://codereview.chromium.org/10443004/diff/2001/ash/system/network/tray_sms.h
File ash/system/network/tray_sms.h (right):

http://codereview.chromium.org/10443004/diff/2001/ash/system/network/tray_sms...
ash/system/network/tray_sms.h:32: virtual bool GetInitialVisibility() OVERRIDE;
This isn't necessary anymore.

http://codereview.chromium.org/10443004/diff/2001/ash/system/tray/tray_views.cc
File ash/system/tray/tray_views.cc (right):

http://codereview.chromium.org/10443004/diff/2001/ash/system/tray/tray_views....
ash/system/tray/tray_views.cc:526: RemoveAllChildViews(true);
The indentation here and in UpdateViewAndImage seems off

[stevenjb, 2012-05-24 16:48:00]

https://chromiumcodereview.appspot.com/10443004/diff/2001/ash/system/locale/t...
File ash/system/locale/tray_locale.h (right):

https://chromiumcodereview.appspot.com/10443004/diff/2001/ash/system/locale/t...
ash/system/locale/tray_locale.h:29: virtual bool GetInitialVisibility()
OVERRIDE;
On 2012/05/24 04:12:50, sadrul wrote:
> This isn't necessary anymore.
Oops, thanks. Done.

https://chromiumcodereview.appspot.com/10443004/diff/2001/ash/system/network/...
File ash/system/network/tray_sms.h (right):

https://chromiumcodereview.appspot.com/10443004/diff/2001/ash/system/network/...
ash/system/network/tray_sms.h:32: virtual bool GetInitialVisibility() OVERRIDE;
On 2012/05/24 04:12:50, sadrul wrote:
> This isn't necessary anymore.

Done.

https://chromiumcodereview.appspot.com/10443004/diff/2001/ash/system/tray/tra...
File ash/system/tray/tray_views.cc (right):

https://chromiumcodereview.appspot.com/10443004/diff/2001/ash/system/tray/tra...
ash/system/tray/tray_views.cc:526: RemoveAllChildViews(true);
On 2012/05/24 04:12:50, sadrul wrote:
> The indentation here and in UpdateViewAndImage seems off

Done.

[jennyz, 2012-05-24 16:55:15]

LGTM with nit.

https://chromiumcodereview.appspot.com/10443004/diff/2001/ash/system/locale/t...
File ash/system/locale/tray_locale.cc (right):

https://chromiumcodereview.appspot.com/10443004/diff/2001/ash/system/locale/t...
ash/system/locale/tray_locale.cc:29: const std::string& cur_locale,
Should this be aligned with the previous argument?

[stevenjb, 2012-05-24 16:58:29]

https://chromiumcodereview.appspot.com/10443004/diff/2001/ash/system/locale/t...
File ash/system/locale/tray_locale.cc (right):

https://chromiumcodereview.appspot.com/10443004/diff/2001/ash/system/locale/t...
ash/system/locale/tray_locale.cc:29: const std::string& cur_locale,
On 2012/05/24 16:55:15, jennyz wrote:
> Should this be aligned with the previous argument?
Oops, thanks. Done.