Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 10442081: Update status files for dart2js/mac/safari. (Closed)

Created:
8 years, 6 months ago by ngeoffray
Modified:
8 years, 6 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update status files for dart2js/mac/safari. Committed: https://code.google.com/p/dart/source/detail?r=8085

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -3 lines) Patch
M dart/samples/tests/samples/samples.status View 1 2 chunks +9 lines, -3 lines 0 comments Download
M dart/tests/corelib/corelib.status View 1 chunk +4 lines, -0 lines 0 comments Download
M dart/tests/isolate/isolate.status View 1 chunk +3 lines, -0 lines 0 comments Download
M dart/tests/language/language_dart2js.status View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
8 years, 6 months ago (2012-05-30 07:13:06 UTC) #1
kasperl
LGTM. https://chromiumcodereview.appspot.com/10442081/diff/1/dart/samples/tests/samples/samples.status File dart/samples/tests/samples/samples.status (right): https://chromiumcodereview.appspot.com/10442081/diff/1/dart/samples/tests/samples/samples.status#newcode90 dart/samples/tests/samples/samples.status:90: lib/touch/touch_test: Fail # Expectation: Solver. Expect.approxEquals(expected:9, actual:8.990625000000001, tolerance:0.0009) ...
8 years, 6 months ago (2012-05-30 07:20:19 UTC) #2
ngeoffray
8 years, 6 months ago (2012-05-30 07:25:55 UTC) #3
https://chromiumcodereview.appspot.com/10442081/diff/1/dart/samples/tests/sam...
File dart/samples/tests/samples/samples.status (right):

https://chromiumcodereview.appspot.com/10442081/diff/1/dart/samples/tests/sam...
dart/samples/tests/samples/samples.status:90: lib/touch/touch_test: Fail #
Expectation: Solver. Expect.approxEquals(expected:9, actual:8.990625000000001,
tolerance:0.0009) fails</td
On 2012/05/30 07:20:19, kasperl wrote:
> Remove </td

Done.

https://chromiumcodereview.appspot.com/10442081/diff/1/dart/tests/language/la...
File dart/tests/language/language.status (right):

https://chromiumcodereview.appspot.com/10442081/diff/1/dart/tests/language/la...
dart/tests/language/language.status:481: [ $compiler == dart2js && $runtime ==
safari ]
On 2012/05/30 07:20:19, kasperl wrote:
> Move this to language_dart2js.status. I'll move the firefox parts in my CL.

Done.

Powered by Google App Engine
This is Rietveld 408576698