Rename GetRootWindow() -> GetPrimaryRootWindow()

Rename GetRootWindow() -> GetPrimaryRootWindow()

BUG=123160
TEST=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138950

[oshima, 2012-05-24 20:10:23]

Some of them will be replaced with GetActiveRootWindow, or should get root
window from relevant window. I'll work on them in separate CL.

[Ben Goodger (Google), 2012-05-24 21:07:57]

Do we need to rename this method, or can we just assert that
Shell::GetRootWindow() always returns the primary, and have an API for accessing
secondaries?

http://codereview.chromium.org/10442017/diff/6002/ash/shell.h
File ash/shell.h (right):

http://codereview.chromium.org/10442017/diff/6002/ash/shell.h#newcode136
ash/shell.h:136: // Gets the prmiary RootWindow. The primary RootWindow is the
root window
primary

http://codereview.chromium.org/10442017/diff/6002/ash/shell.h#newcode137
ash/shell.h:137: // that has a laucnher.
launcher

[oshima, 2012-05-24 22:14:19]

On 2012/05/24 21:07:57, Ben Goodger (Google) wrote:
> Do we need to rename this method, or can we just assert that
> Shell::GetRootWindow() always returns the primary, and have an API for
accessing
> secondaries?

I want to emphasize that there are more than one RootWindow, and a caller must
be
aware of which RootWindow it is asking. That is, if you need a RootWindow which
has
launcher (for app list, locker etc), then it should use GetPrimaryRootWindow. If
 you need
active root window, use GetActiveRootWindow(). For other cases, it should use
Window::GetRootWindow() instead of Shell's accessor. (There are cases where
Window::GetRootWindow is appropriate and sufficient, but using
Shell::GetRootWindow)

We may need GetRootWindowAt() for the case where you need a root window at mouse
location,
although I'm not 100% sure yet.

> 
> http://codereview.chromium.org/10442017/diff/6002/ash/shell.h
> File ash/shell.h (right):
> 
> http://codereview.chromium.org/10442017/diff/6002/ash/shell.h#newcode136
> ash/shell.h:136: // Gets the prmiary RootWindow. The primary RootWindow is the
> root window
> primary
> 
> http://codereview.chromium.org/10442017/diff/6002/ash/shell.h#newcode137
> ash/shell.h:137: // that has a laucnher.
> launcher

Done. Sorry about typos. I'll be more careful.

[Ben Goodger (Google), 2012-05-24 22:17:35]

LGTM

On Thu, May 24, 2012 at 3:14 PM, <oshima@chromium.org> wrote:

> On 2012/05/24 21:07:57, Ben Goodger (Google) wrote:
>
>> Do we need to rename this method, or can we just assert that
>> Shell::GetRootWindow() always returns the primary, and have an API for
>>
> accessing
>
>> secondaries?
>>
>
> I want to emphasize that there are more than one RootWindow, and a caller
> must
> be
> aware of which RootWindow it is asking. That is, if you need a RootWindow
> which
> has
> launcher (for app list, locker etc), then it should use
> GetPrimaryRootWindow. If
>  you need
> active root window, use GetActiveRootWindow(). For other cases, it should
> use
> Window::GetRootWindow() instead of Shell's accessor. (There are cases where
> Window::GetRootWindow is appropriate and sufficient, but using
> Shell::GetRootWindow)
>
> We may need GetRootWindowAt() for the case where you need a root window at
> mouse
> location,
> although I'm not 100% sure yet.
>
>
>
> 
http://codereview.chromium.**org/10442017/diff/6002/ash/**shell.h<http://code...
>> File ash/shell.h (right):
>>
>
>  http://codereview.chromium.**org/10442017/diff/6002/ash/**
>>
shell.h#newcode136<http://codereview.chromium.org/10442017/diff/6002/ash/shell.h#newcode136>
>> ash/shell.h:136: // Gets the prmiary RootWindow. The primary RootWindow
>> is the
>> root window
>> primary
>>
>
>  http://codereview.chromium.**org/10442017/diff/6002/ash/**
>>
shell.h#newcode137<http://codereview.chromium.org/10442017/diff/6002/ash/shell.h#newcode137>
>> ash/shell.h:137: // that has a laucnher.
>> launcher
>>
>
> Done. Sorry about typos. I'll be more careful.
>
>
>
>
http://codereview.chromium.**org/10442017/<http://codereview.chromium.org/104...
>

[commit-bot: I haz the power, 2012-05-24 22:21:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10442017/12001

[commit-bot: I haz the power, 2012-05-24 22:49:27]

Try job failure for 10442017-12001 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...