Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Side by Side Diff: ash/accelerators/nested_dispatcher_controller_unittest.cc

Issue 10442017: Rename GetRootWindow() -> GetPrimaryRootWindow() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: git-try -b linux_chromeos,win_aura Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ash/accelerators/nested_dispatcher_controller.cc ('k') | ash/dip_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/accelerators/accelerator_controller.h" 5 #include "ash/accelerators/accelerator_controller.h"
6 #include "ash/shell.h" 6 #include "ash/shell.h"
7 #include "ash/shell_delegate.h" 7 #include "ash/shell_delegate.h"
8 #include "ash/shell_window_ids.h" 8 #include "ash/shell_window_ids.h"
9 #include "ash/test/ash_test_base.h" 9 #include "ash/test/ash_test_base.h"
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 71
72 DISALLOW_COPY_AND_ASSIGN(TestTarget); 72 DISALLOW_COPY_AND_ASSIGN(TestTarget);
73 }; 73 };
74 74
75 void DispatchKeyReleaseA() { 75 void DispatchKeyReleaseA() {
76 // Sending both keydown and keyup is necessary here because the accelerator 76 // Sending both keydown and keyup is necessary here because the accelerator
77 // manager only checks a keyup event following a keydown event. See 77 // manager only checks a keyup event following a keydown event. See
78 // ShouldHandle() in ui/base/accelerators/accelerator_manager.cc for details. 78 // ShouldHandle() in ui/base/accelerators/accelerator_manager.cc for details.
79 #if defined(OS_WIN) 79 #if defined(OS_WIN)
80 MSG native_event_down = { NULL, WM_KEYDOWN, ui::VKEY_A, 0 }; 80 MSG native_event_down = { NULL, WM_KEYDOWN, ui::VKEY_A, 0 };
81 ash::Shell::GetRootWindow()->PostNativeEvent(native_event_down); 81 ash::Shell::GetPrimaryRootWindow()->PostNativeEvent(native_event_down);
82 MSG native_event_up = { NULL, WM_KEYUP, ui::VKEY_A, 0 }; 82 MSG native_event_up = { NULL, WM_KEYUP, ui::VKEY_A, 0 };
83 ash::Shell::GetRootWindow()->PostNativeEvent(native_event_up); 83 ash::Shell::GetPrimaryRootWindow()->PostNativeEvent(native_event_up);
84 #elif defined(USE_X11) 84 #elif defined(USE_X11)
85 XEvent native_event; 85 XEvent native_event;
86 ui::InitXKeyEventForTesting(ui::ET_KEY_PRESSED, 86 ui::InitXKeyEventForTesting(ui::ET_KEY_PRESSED,
87 ui::VKEY_A, 87 ui::VKEY_A,
88 0, 88 0,
89 &native_event); 89 &native_event);
90 ash::Shell::GetRootWindow()->PostNativeEvent(&native_event); 90 ash::Shell::GetPrimaryRootWindow()->PostNativeEvent(&native_event);
91 ui::InitXKeyEventForTesting(ui::ET_KEY_RELEASED, 91 ui::InitXKeyEventForTesting(ui::ET_KEY_RELEASED,
92 ui::VKEY_A, 92 ui::VKEY_A,
93 0, 93 0,
94 &native_event); 94 &native_event);
95 ash::Shell::GetRootWindow()->PostNativeEvent(&native_event); 95 ash::Shell::GetPrimaryRootWindow()->PostNativeEvent(&native_event);
96 #endif 96 #endif
97 97
98 // Send noop event to signal dispatcher to exit. 98 // Send noop event to signal dispatcher to exit.
99 ash::Shell::GetRootWindow()->PostNativeEvent(ui::CreateNoopEvent()); 99 ash::Shell::GetPrimaryRootWindow()->PostNativeEvent(ui::CreateNoopEvent());
100 } 100 }
101 101
102 } // namespace 102 } // namespace
103 103
104 typedef AshTestBase NestedDispatcherTest; 104 typedef AshTestBase NestedDispatcherTest;
105 105
106 // Aura window below lock screen in z order. 106 // Aura window below lock screen in z order.
107 TEST_F(NestedDispatcherTest, AssociatedWindowBelowLockScreen) { 107 TEST_F(NestedDispatcherTest, AssociatedWindowBelowLockScreen) {
108 MockDispatcher inner_dispatcher; 108 MockDispatcher inner_dispatcher;
109 aura::Window* default_container = Shell::GetInstance()->GetContainer( 109 aura::Window* default_container = Shell::GetInstance()->GetContainer(
110 internal::kShellWindowId_DefaultContainer); 110 internal::kShellWindowId_DefaultContainer);
111 scoped_ptr<aura::Window> associated_window(aura::test::CreateTestWindowWithId( 111 scoped_ptr<aura::Window> associated_window(aura::test::CreateTestWindowWithId(
112 0, default_container)); 112 0, default_container));
113 113
114 Shell::GetInstance()->delegate()->LockScreen(); 114 Shell::GetInstance()->delegate()->LockScreen();
115 DispatchKeyReleaseA(); 115 DispatchKeyReleaseA();
116 aura::RootWindow* root_window = ash::Shell::GetInstance()->GetRootWindow(); 116 aura::RootWindow* root_window = ash::Shell::GetPrimaryRootWindow();
117 aura::client::GetDispatcherClient(root_window)->RunWithDispatcher( 117 aura::client::GetDispatcherClient(root_window)->RunWithDispatcher(
118 &inner_dispatcher, 118 &inner_dispatcher,
119 associated_window.get(), 119 associated_window.get(),
120 true /* nestable_tasks_allowed */); 120 true /* nestable_tasks_allowed */);
121 EXPECT_EQ(0, inner_dispatcher.num_key_events_dispatched()); 121 EXPECT_EQ(0, inner_dispatcher.num_key_events_dispatched());
122 Shell::GetInstance()->delegate()->UnlockScreen(); 122 Shell::GetInstance()->delegate()->UnlockScreen();
123 } 123 }
124 124
125 // Aura window above lock screen in z order. 125 // Aura window above lock screen in z order.
126 TEST_F(NestedDispatcherTest, AssociatedWindowAboveLockScreen) { 126 TEST_F(NestedDispatcherTest, AssociatedWindowAboveLockScreen) {
127 MockDispatcher inner_dispatcher; 127 MockDispatcher inner_dispatcher;
128 128
129 aura::Window* default_container = Shell::GetInstance()->GetContainer( 129 aura::Window* default_container = Shell::GetInstance()->GetContainer(
130 internal::kShellWindowId_DefaultContainer); 130 internal::kShellWindowId_DefaultContainer);
131 scoped_ptr<aura::Window>mock_lock_container( 131 scoped_ptr<aura::Window>mock_lock_container(
132 aura::test::CreateTestWindowWithId(0, default_container)); 132 aura::test::CreateTestWindowWithId(0, default_container));
133 aura::test::CreateTestWindowWithId(0, mock_lock_container.get()); 133 aura::test::CreateTestWindowWithId(0, mock_lock_container.get());
134 scoped_ptr<aura::Window>associated_window(aura::test::CreateTestWindowWithId( 134 scoped_ptr<aura::Window>associated_window(aura::test::CreateTestWindowWithId(
135 0, default_container)); 135 0, default_container));
136 EXPECT_TRUE(aura::test::WindowIsAbove(associated_window.get(), 136 EXPECT_TRUE(aura::test::WindowIsAbove(associated_window.get(),
137 mock_lock_container.get())); 137 mock_lock_container.get()));
138 138
139 DispatchKeyReleaseA(); 139 DispatchKeyReleaseA();
140 aura::RootWindow* root_window = ash::Shell::GetInstance()->GetRootWindow(); 140 aura::RootWindow* root_window = ash::Shell::GetPrimaryRootWindow();
141 aura::client::GetDispatcherClient(root_window)->RunWithDispatcher( 141 aura::client::GetDispatcherClient(root_window)->RunWithDispatcher(
142 &inner_dispatcher, 142 &inner_dispatcher,
143 associated_window.get(), 143 associated_window.get(),
144 true /* nestable_tasks_allowed */); 144 true /* nestable_tasks_allowed */);
145 EXPECT_EQ(1, inner_dispatcher.num_key_events_dispatched()); 145 EXPECT_EQ(1, inner_dispatcher.num_key_events_dispatched());
146 } 146 }
147 147
148 // Test that the nested dispatcher handles accelerators. 148 // Test that the nested dispatcher handles accelerators.
149 TEST_F(NestedDispatcherTest, AcceleratorsHandled) { 149 TEST_F(NestedDispatcherTest, AcceleratorsHandled) {
150 MockDispatcher inner_dispatcher; 150 MockDispatcher inner_dispatcher;
151 aura::RootWindow* root_window = ash::Shell::GetInstance()->GetRootWindow(); 151 aura::RootWindow* root_window = ash::Shell::GetPrimaryRootWindow();
152 152
153 ui::Accelerator accelerator(ui::VKEY_A, ui::EF_NONE); 153 ui::Accelerator accelerator(ui::VKEY_A, ui::EF_NONE);
154 accelerator.set_type(ui::ET_KEY_RELEASED); 154 accelerator.set_type(ui::ET_KEY_RELEASED);
155 TestTarget target; 155 TestTarget target;
156 Shell::GetInstance()->accelerator_controller()->Register(accelerator, 156 Shell::GetInstance()->accelerator_controller()->Register(accelerator,
157 &target); 157 &target);
158 158
159 DispatchKeyReleaseA(); 159 DispatchKeyReleaseA();
160 aura::client::GetDispatcherClient(root_window)->RunWithDispatcher( 160 aura::client::GetDispatcherClient(root_window)->RunWithDispatcher(
161 &inner_dispatcher, 161 &inner_dispatcher,
162 root_window, 162 root_window,
163 true /* nestable_tasks_allowed */); 163 true /* nestable_tasks_allowed */);
164 EXPECT_EQ(0, inner_dispatcher.num_key_events_dispatched()); 164 EXPECT_EQ(0, inner_dispatcher.num_key_events_dispatched());
165 EXPECT_EQ(1, target.accelerator_pressed_count()); 165 EXPECT_EQ(1, target.accelerator_pressed_count());
166 } 166 }
167 167
168 } // namespace test 168 } // namespace test
169 } // namespace ash 169 } // namespace ash
OLDNEW
« no previous file with comments | « ash/accelerators/nested_dispatcher_controller.cc ('k') | ash/dip_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698