Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Side by Side Diff: Source/WebCore/rendering/RenderBox.cpp

Issue 10442005: Merge 116476 (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1132/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/page/FrameView.cpp ('k') | Source/WebCore/rendering/RenderLayer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com) 5 * (C) 2005, 2006 Samuel Weinig (sam.weinig@gmail.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
249 { 249 {
250 clearOverrideSize(); 250 clearOverrideSize();
251 251
252 RenderStyle* styleToUse = style(); 252 RenderStyle* styleToUse = style();
253 if (styleToUse && (styleToUse->logicalHeight().isPercent() || styleToUse->lo gicalMinHeight().isPercent() || styleToUse->logicalMaxHeight().isPercent())) 253 if (styleToUse && (styleToUse->logicalHeight().isPercent() || styleToUse->lo gicalMinHeight().isPercent() || styleToUse->logicalMaxHeight().isPercent()))
254 RenderBlock::removePercentHeightDescendant(this); 254 RenderBlock::removePercentHeightDescendant(this);
255 255
256 if (styleToUse) { 256 if (styleToUse) {
257 if (RenderView* view = this->view()) { 257 if (RenderView* view = this->view()) {
258 if (FrameView* frameView = view->frameView()) { 258 if (FrameView* frameView = view->frameView()) {
259 // If this renderer is owning renderer for the FrameView's custo m scrollbars,
260 // we need to clear it from the scrollbar. See webkit bug 64737.
261 if (styleToUse->hasPseudoStyle(SCROLLBAR))
262 frameView->clearOwningRendererForCustomScrollbars(this);
263
264 if (styleToUse->position() == FixedPosition) 259 if (styleToUse->position() == FixedPosition)
265 frameView->removeFixedObject(); 260 frameView->removeFixedObject();
266 } 261 }
267 } 262 }
268 } 263 }
269 264
270 // If the following assertion fails, logicalHeight()/logicalMinHeight()/ 265 // If the following assertion fails, logicalHeight()/logicalMinHeight()/
271 // logicalMaxHeight() values are changed from a percent value to a non-perce nt 266 // logicalMaxHeight() values are changed from a percent value to a non-perce nt
272 // value during laying out. It causes a use-after-free bug. 267 // value during laying out. It causes a use-after-free bug.
273 ASSERT(!RenderBlock::hasPercentHeightDescendant(this)); 268 ASSERT(!RenderBlock::hasPercentHeightDescendant(this));
(...skipping 3801 matching lines...) Expand 10 before | Expand all | Expand 10 after
4075 } 4070 }
4076 4071
4077 if (didSplitParentAnonymousBoxes) 4072 if (didSplitParentAnonymousBoxes)
4078 markBoxForRelayoutAfterSplit(this); 4073 markBoxForRelayoutAfterSplit(this);
4079 4074
4080 ASSERT(beforeChild->parent() == this); 4075 ASSERT(beforeChild->parent() == this);
4081 return beforeChild; 4076 return beforeChild;
4082 } 4077 }
4083 4078
4084 } // namespace WebCore 4079 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/WebCore/page/FrameView.cpp ('k') | Source/WebCore/rendering/RenderLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698