Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10441140: Make context groups share a TextureBufferManager (Closed)

Created:
8 years, 6 months ago by greggman
Modified:
8 years, 6 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Make context groups share a TextureBufferManager TEST=unit tests, and ran WebGL Conformance tests BUG=129803 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139981

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -30 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +2 lines, -1 line 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper_test.cc View 3 chunks +10 lines, -2 lines 2 comments Download
M gpu/command_buffer/client/fenced_allocator_test.cc View 3 chunks +9 lines, -1 line 0 comments Download
M gpu/command_buffer/client/mapped_memory_unittest.cc View 3 chunks +11 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/ring_buffer_test.cc View 3 chunks +10 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service.h View 3 chunks +5 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service_unittest.cc View 3 chunks +9 lines, -1 line 0 comments Download
M gpu/command_buffer/service/context_group.h View 4 chunks +9 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 2 chunks +10 lines, -2 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +9 lines, -6 lines 0 comments Download
M gpu/demos/framework/window.h View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/demos/framework/window.cc View 2 chunks +8 lines, -1 line 0 comments Download
M gpu/gles2_conform_support/egl/display.h View 2 chunks +2 lines, -0 lines 0 comments Download
M gpu/gles2_conform_support/egl/display.cc View 2 chunks +7 lines, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 4 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
greggman
Hey Al, PTAL
8 years, 6 months ago (2012-05-31 23:44:33 UTC) #1
apatrick_chromium
lgtm https://chromiumcodereview.appspot.com/10441140/diff/1/gpu/command_buffer/client/cmd_buffer_helper_test.cc File gpu/command_buffer/client/cmd_buffer_helper_test.cc (right): https://chromiumcodereview.appspot.com/10441140/diff/1/gpu/command_buffer/client/cmd_buffer_helper_test.cc#newcode69 gpu/command_buffer/client/cmd_buffer_helper_test.cc:69: { Why is this in a block?
8 years, 6 months ago (2012-05-31 23:57:33 UTC) #2
greggman
https://chromiumcodereview.appspot.com/10441140/diff/1/gpu/command_buffer/client/cmd_buffer_helper_test.cc File gpu/command_buffer/client/cmd_buffer_helper_test.cc (right): https://chromiumcodereview.appspot.com/10441140/diff/1/gpu/command_buffer/client/cmd_buffer_helper_test.cc#newcode69 gpu/command_buffer/client/cmd_buffer_helper_test.cc:69: { On 2012/05/31 23:57:33, apatrick_chromium wrote: > Why is ...
8 years, 6 months ago (2012-06-01 00:01:44 UTC) #3
apatrick_chromium
Fair enough. LGTM.
8 years, 6 months ago (2012-06-01 00:02:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/10441140/1
8 years, 6 months ago (2012-06-01 04:43:27 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-01 06:13:43 UTC) #6 
Change committed as 139981

Powered by Google App Engine
This is Rietveld 408576698