Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 10441101: Revert 124453 - WebWidgetClient::screenInfo() no longer does a synchronous IPC. (Closed)

Created:
8 years, 6 months ago by varunjain
Modified:
8 years, 6 months ago
Reviewers:
Fady Samuel, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Visibility:
Public.

Description

Revert 124453 - WebWidgetClient::screenInfo() no longer does a synchronous IPC. Instead it grabs the necessary info from a cached WebScreenInfo factory. BUG=111401, 126586 TEST=Manually Review URL: http://codereview.chromium.org/9302022 TBR=fsamuel@chromium.org,jam@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140030

Patch Set 1 #

Patch Set 2 : patch #

Patch Set 3 : patch #

Patch Set 4 : perged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -42 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter_win.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 2 chunks +0 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 2 3 2 chunks +9 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 2 3 2 chunks +7 lines, -3 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_channel_manager.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 5 chunks +2 lines, -6 lines 0 comments Download
M content/renderer/render_widget.h View 1 3 chunks +1 line, -6 lines 0 comments Download
M content/renderer/render_widget.cc View 1 4 chunks +15 lines, -6 lines 0 comments Download
M content/renderer/render_widget_fullscreen.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/test/render_view_test.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
varunjain
8 years, 6 months ago (2012-05-30 19:55:18 UTC) #1
Fady Samuel
lgtm
8 years, 6 months ago (2012-05-30 19:56:45 UTC) #2
varunjain
On 2012/05/30 19:56:45, Fady Samuel wrote: > lgtm Hi Fady... please have another look at ...
8 years, 6 months ago (2012-05-30 20:31:38 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 6 months ago (2012-05-30 21:06:18 UTC) #4
varunjain
+jam for OWNERS do I can commit this through cq. On 2012/05/30 21:06:18, I haz ...
8 years, 6 months ago (2012-05-30 21:11:00 UTC) #5
jam
lgtm
8 years, 6 months ago (2012-05-31 06:00:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10441101/10
8 years, 6 months ago (2012-05-31 23:56:09 UTC) #7
commit-bot: I haz the power
Try job failure for 10441101-10 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-01 01:19:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10441101/5005
8 years, 6 months ago (2012-06-01 02:45:35 UTC) #9
commit-bot: I haz the power
Try job failure for 10441101-5005 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 6 months ago (2012-06-01 05:22:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10441101/5005
8 years, 6 months ago (2012-06-01 13:20:33 UTC) #11
commit-bot: I haz the power
8 years, 6 months ago (2012-06-01 15:39:28 UTC) #12
Change committed as 140030

Powered by Google App Engine
This is Rietveld 408576698