content/common/view_messages.h - Issue 10441101: Revert 124453 - WebWidgetClient::screenInfo() no longer does a synchronous IPC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/view_messages.h

Issue 10441101: Revert 124453 - WebWidgetClient::screenInfo() no longer does a synchronous IPC. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: perged Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/renderer/browser_plugin/browser_plugin_channel_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/view_messages.h

diff --git a/content/common/view_messages.h b/content/common/view_messages.h

index 0e461f5fe66bea6ce9e2100f8be57f12f7857368..72689cf18da20c02205f2ef7afc901a926a73e3d 100644

--- a/content/common/view_messages.h

+++ b/content/common/view_messages.h

@@ -681,9 +681,6 @@ IPC_STRUCT_BEGIN(ViewMsg_New_Params)

// to a view and are only updated by the renderer after this initial value.

IPC_STRUCT_MEMBER(int32, next_page_id)

- // The properties of the screen associated with the view.

- IPC_STRUCT_MEMBER(WebKit::WebScreenInfo, screen_info)

// The name of the channel with which a guest talks to its embedder.

// If this newly created RenderView has no embedder this string will be

// empty.

@@ -1763,6 +1760,13 @@ IPC_SYNC_MESSAGE_CONTROL1_3(ViewHostMsg_LoadFont,

uint32 /* font id */)

#endif

+// Returns WebScreenInfo corresponding to the view.

+// TODO(shess): Provide a mapping from reply_msg->routing_id() to

+// HWND so that we can eliminate the NativeViewId parameter.

+IPC_SYNC_MESSAGE_ROUTED1_1(ViewHostMsg_GetScreenInfo,

+ gfx::NativeViewId /* view */,

+ WebKit::WebScreenInfo /* results */)

// Send the tooltip text for the current mouse position to the browser.

IPC_MESSAGE_ROUTED2(ViewHostMsg_SetTooltipText,

string16 /* tooltip text string */,