Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 10440115: Turn on audio mixer by default. (Closed)

Created:
8 years, 6 months ago by enal
Modified:
8 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Turn on audio mixer by default. BUG=114701 TEST=Should be no audiable difference, at least without very high load. TEST=We would open fewer OS audio streams, but that is not noticeable. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140071

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M media/audio/audio_manager_base.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_switches.h View 1 1 chunk +1 line, -1 line 0 comments Download
M media/base/media_switches.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
enal1
Andrew, can you please review?
8 years, 6 months ago (2012-05-31 18:01:29 UTC) #1
scherkus (not reviewing)
https://chromiumcodereview.appspot.com/10440115/diff/1/media/base/media_switches.cc File media/base/media_switches.cc (left): https://chromiumcodereview.appspot.com/10440115/diff/1/media/base/media_switches.cc#oldcode30 media/base/media_switches.cc:30: const char kEnableAudioMixer[] = "enable-audio-mixer"; this should be changed ...
8 years, 6 months ago (2012-05-31 18:15:28 UTC) #2
enal1
On 2012/05/31 18:15:28, scherkus wrote: > https://chromiumcodereview.appspot.com/10440115/diff/1/media/base/media_switches.cc > File media/base/media_switches.cc (left): > > https://chromiumcodereview.appspot.com/10440115/diff/1/media/base/media_switches.cc#oldcode30 > ...
8 years, 6 months ago (2012-05-31 18:21:39 UTC) #3
scherkus (not reviewing)
lgtm!
8 years, 6 months ago (2012-06-01 00:37:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/10440115/3002
8 years, 6 months ago (2012-06-01 01:12:02 UTC) #5
commit-bot: I haz the power
Try job failure for 10440115-3002 (retry) on mac_rel for step "content_unittests". It's a second try, ...
8 years, 6 months ago (2012-06-01 01:53:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/10440115/2004
8 years, 6 months ago (2012-06-01 16:08:07 UTC) #7
commit-bot: I haz the power
Change committed as 140071
8 years, 6 months ago (2012-06-01 19:05:09 UTC) #8
scherkus (not reviewing)
8 years, 6 months ago (2012-06-01 19:07:57 UTC) #9
woo hoo!

Powered by Google App Engine
This is Rietveld 408576698