Remove the enable_metro GYP flag, effectively making it on by default.

Remove the enable_metro GYP flag, effectively making it on by default.

The flag was mostly redundant with the enable_touch_ui flag, the only
additional effect of turning it on was to change the behavior of
ui::GetDisplayLayout.

If we later wanted to duplicate the effect that disabling the
enable_metro flag prior to this change would have, we can simply
change the condition in common.gypi that determines whether to turn on
the enable_touch_ui flag.

BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139181

[Jói, 2012-05-24 22:54:45]

Ananta:  Primary reviewer.
Scott:  ui/OWNERS.

Cheers,
Jói

[ananta, 2012-05-24 23:25:07]

LGTM

[sky, 2012-05-24 23:45:34]

Can you also reenable touch-optimized-ui in about_flags for windows?

http://codereview.chromium.org/10440037/diff/1/chrome/installer/mini_installe...
File chrome/installer/mini_installer.gyp (right):

http://codereview.chromium.org/10440037/diff/1/chrome/installer/mini_installe...
chrome/installer/mini_installer.gyp:209: 'enable_touch_ui_flag':
'--enable_touch_ui=1',
I'm not familiar with the mini installer. Will this set --enable-touch-ui for
every one?

[Jói, 2012-05-25 10:30:18]

> Can you also reenable touch-optimized-ui in about_flags for windows?

I'm on vacation today and will be back on Tuesday.  If it's OK by you I could do
this as a follow-up change next week; it's also slightly orthogonal to the GYP
flag removal.

Given this, if you are OK with the patch as-is, then I would ask either you or
Ananta to pull the CQ trigger, as I am about to leave town for the weekend.

Ananta:  If the patch needs more work and you guys want it to land before
Tuesday, then perhaps you or one of our other teammates could take it over and
land it?

Cheers,
Jói

http://codereview.chromium.org/10440037/diff/1/chrome/installer/mini_installe...
File chrome/installer/mini_installer.gyp (right):

http://codereview.chromium.org/10440037/diff/1/chrome/installer/mini_installe...
chrome/installer/mini_installer.gyp:209: 'enable_touch_ui_flag':
'--enable_touch_ui=1',
On 2012/05/24 23:45:34, sky wrote:
> I'm not familiar with the mini installer. Will this set --enable-touch-ui for
> every one?

This will cause the assets needed for the touch layout to be included in the
installer for everyone.  The layout won't actually be displayed except when
running in Metro.

[sky, 2012-05-25 15:46:49]

I'm fine with follup for about_flags: LGTM

[ananta, 2012-05-26 00:05:13]

On 2012/05/25 15:46:49, sky wrote:
> I'm fine with follup for about_flags: LGTM

LGTM. I am pulling the CQ trigger now.

[commit-bot: I haz the power, 2012-05-26 00:05:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/10440037/1

[commit-bot: I haz the power, 2012-05-26 04:34:21]

Change committed as 139181