Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Unified Diff: build/common.gypi

Issue 10440037: Remove the enable_metro GYP flag, effectively making it on by default. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/installer/mini_installer.gyp » ('j') | chrome/installer/mini_installer.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index a0e9ab3db1c03077eb1f5b12db2310ff242bdecf..0fa3e074566b63ebfc0d1c2e4c702c666993a841 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -43,10 +43,6 @@
# Enable touch optimized art assets and metrics.
'enable_touch_ui%': 0,
- # Enable inclusion of touch-optimized resources.
- # TODO(joi): Rename to enable_touch_assets.
- 'enable_metro%': 0,
-
# Is this change part of the android upstream bringup?
# Allows us to *temporarily* disable certain things for
# staging. Only set to 1 in a GYP_DEFINES.
@@ -71,7 +67,6 @@
'enable_viewport%': '<(enable_viewport)',
'enable_hidpi%': '<(enable_hidpi)',
'enable_touch_ui%': '<(enable_touch_ui)',
- 'enable_metro%': '<(enable_metro)',
'android_upstream_bringup%': '<(android_upstream_bringup)',
'buildtype%': '<(buildtype)',
@@ -117,7 +112,7 @@
}],
# Enable touch UI on Metro and Chrome OS.
- ['enable_metro==1 or chromeos==1', {
+ ['OS=="win" or chromeos==1', {
'enable_touch_ui%': 1,
}],
],
@@ -134,7 +129,6 @@
'enable_viewport%': '<(enable_viewport)',
'enable_hidpi%': '<(enable_hidpi)',
'enable_touch_ui%': '<(enable_touch_ui)',
- 'enable_metro%': '<(enable_metro)',
'android_upstream_bringup%': '<(android_upstream_bringup)',
# We used to provide a variable for changing how libraries were built.
@@ -532,7 +526,6 @@
'enable_viewport%': '<(enable_viewport)',
'enable_hidpi%': '<(enable_hidpi)',
'enable_touch_ui%': '<(enable_touch_ui)',
- 'enable_metro%': '<(enable_metro)',
'use_xi2_mt%':'<(use_xi2_mt)',
'file_manager_extension%': '<(file_manager_extension)',
'webui_task_manager%': '<(webui_task_manager)',
@@ -1351,9 +1344,6 @@
['enable_hidpi==1', {
'defines': ['ENABLE_HIDPI=1'],
}],
- ['enable_metro==1', {
- 'defines': ['ENABLE_METRO=1'],
- }],
['OS=="android" and gtest_target_type=="shared_library"', {
'defines': ['ANDROID_APK_TEST_TARGET=1'],
}],
« no previous file with comments | « no previous file | chrome/installer/mini_installer.gyp » ('j') | chrome/installer/mini_installer.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698