Index: chrome/browser/ui/extensions/shell_window.cc |
diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc |
index 1e9811d19569b7d28901d18bd197b1c26fa6ec71..94322b58c5f8f37ec6bf3998f624de9fc7ab153c 100644 |
--- a/chrome/browser/ui/extensions/shell_window.cc |
+++ b/chrome/browser/ui/extensions/shell_window.cc |
@@ -40,6 +40,8 @@ static const int kDefaultHeight = 384; |
namespace internal { |
+const char kWindowTypeValueShell[] = "shell"; |
+ |
class ShellWindowController : public ExtensionWindowController { |
public: |
ShellWindowController(ShellWindow* shell_window, Profile* profile); |
@@ -72,7 +74,10 @@ int ShellWindowController::GetWindowId() const { |
} |
std::string ShellWindowController::GetWindowTypeText() const { |
- return extension_tabs_module_constants::kWindowTypeValueShell; |
+ // TODO(jeremya): since this window shouldn't be accessible from the tabs |
+ // API, does it still make sense for it to have a valid window type? Perhaps |
+ // this should NOTREACHED(). |
Mihai Parparita -not on Chrome
2012/05/29 06:09:13
NOTREACHED SGTM
jeremya
2012/05/30 01:10:47
Done.
|
+ return kWindowTypeValueShell; |
} |
base::DictionaryValue* ShellWindowController::CreateWindowValueWithTabs() |