Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6113)

Unified Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 10436015: Remove chrome.windows.* support for platform apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/shell_window.cc
diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc
index 1e9811d19569b7d28901d18bd197b1c26fa6ec71..94322b58c5f8f37ec6bf3998f624de9fc7ab153c 100644
--- a/chrome/browser/ui/extensions/shell_window.cc
+++ b/chrome/browser/ui/extensions/shell_window.cc
@@ -40,6 +40,8 @@ static const int kDefaultHeight = 384;
namespace internal {
+const char kWindowTypeValueShell[] = "shell";
+
class ShellWindowController : public ExtensionWindowController {
public:
ShellWindowController(ShellWindow* shell_window, Profile* profile);
@@ -72,7 +74,10 @@ int ShellWindowController::GetWindowId() const {
}
std::string ShellWindowController::GetWindowTypeText() const {
- return extension_tabs_module_constants::kWindowTypeValueShell;
+ // TODO(jeremya): since this window shouldn't be accessible from the tabs
+ // API, does it still make sense for it to have a valid window type? Perhaps
+ // this should NOTREACHED().
Mihai Parparita -not on Chrome 2012/05/29 06:09:13 NOTREACHED SGTM
jeremya 2012/05/30 01:10:47 Done.
+ return kWindowTypeValueShell;
}
base::DictionaryValue* ShellWindowController::CreateWindowValueWithTabs()
« no previous file with comments | « chrome/browser/extensions/extension_tabs_module_constants.cc ('k') | chrome/common/extensions/api/_permission_features.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698