Remove chrome.windows.* support for platform apps.

chrome/browser/ui/extensions/shell_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/extensions/shell_window.h"
 
 #include "chrome/browser/extensions/extension_process_manager.h"
 #include "chrome/browser/extensions/extension_tabs_module_constants.h"
 #include "chrome/browser/extensions/extension_window_controller.h"
 #include "chrome/browser/extensions/shell_window_registry.h"
@@ skipping 22 matching lines @@
 using content::SiteInstance;
 using content::WebContents;
 
 namespace {
 static const int kDefaultWidth = 512;
 static const int kDefaultHeight = 384;
 }  // namespace
 
 namespace internal {
 
+const char kWindowTypeValueShell[] = "shell";
+
 class ShellWindowController : public ExtensionWindowController {
  public:
   ShellWindowController(ShellWindow* shell_window, Profile* profile);
 
   // Overriden from ExtensionWindowController
   virtual int GetWindowId() const OVERRIDE;
   virtual std::string GetWindowTypeText() const OVERRIDE;
   virtual base::DictionaryValue* CreateWindowValueWithTabs() const OVERRIDE;
   virtual bool CanClose(Reason* reason) const OVERRIDE;
   virtual void SetFullscreenMode(bool is_fullscreen,
@@ skipping 12 matching lines @@
     Profile* profile)
     : ExtensionWindowController(shell_window, profile),
       shell_window_(shell_window) {
 }
 
 int ShellWindowController::GetWindowId() const {
   return static_cast<int>(shell_window_->session_id().id());
 }
 
 std::string ShellWindowController::GetWindowTypeText() const {
-  return extension_tabs_module_constants::kWindowTypeValueShell;
+  // TODO(jeremya): since this window shouldn't be accessible from the tabs
+  // API, does it still make sense for it to have a valid window type? Perhaps
+  // this should NOTREACHED().

[Mihai Parparita -not on Chrome, 2012/05/29 06:09:13]

NOTREACHED SGTM

[jeremya, 2012/05/30 01:10:47]

Done.

+  return kWindowTypeValueShell;
 }
 
 base::DictionaryValue* ShellWindowController::CreateWindowValueWithTabs()
     const {
   return CreateWindowValue();
 }
 
 bool ShellWindowController::CanClose(Reason* reason) const {
   return true;
 }
@@ skipping 139 matching lines @@
 }
 
 ExtensionWindowController* ShellWindow::GetExtensionWindowController() const {
   return extension_window_controller_.get();
 }
 
 void ShellWindow::OnRequest(const ExtensionHostMsg_Request_Params& params) {
   extension_function_dispatcher_.Dispatch(params,
                                           web_contents_->GetRenderViewHost());
 }