Remove chrome.windows.* support for platform apps.

Remove chrome.windows.* support for platform apps.

Use chrome.appWindow.* instead.

R=mihaip@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140947

[Mihai Parparita -not on Chrome, 2012-05-24 21:16:03]

There are a few other platform app browser tests that use chrome.windows.create:

http://code.google.com/p/chromium/source/search?origq=chrome.windows.create+f...

http://codereview.chromium.org/10436015/diff/1/chrome/test/data/extensions/pl...
File chrome/test/data/extensions/platform_apps/windows_api/test.js (right):

http://codereview.chromium.org/10436015/diff/1/chrome/test/data/extensions/pl...
chrome/test/data/extensions/platform_apps/windows_api/test.js:11:
chrome.test.assertTrue(win.true);
Does this actually work? "true" is not a property of Window (or a global
variable), and it's not defined in test.html either.

http://codereview.chromium.org/10436015/diff/1/chrome/test/data/extensions/pl...
chrome/test/data/extensions/platform_apps/windows_api/test.js:16:
chrome.windows.create('test.html', {width: 128, height: 128},
This needs to be updated to chrome.appWindow.create too.

[jeremya, 2012-05-28 04:30:03]

Tests are passing now.

https://chromiumcodereview.appspot.com/10436015/diff/1/chrome/test/data/exten...
File chrome/test/data/extensions/platform_apps/windows_api/test.js (right):

https://chromiumcodereview.appspot.com/10436015/diff/1/chrome/test/data/exten...
chrome/test/data/extensions/platform_apps/windows_api/test.js:11:
chrome.test.assertTrue(win.true);
On 2012/05/24 21:16:04, Mihai Parparita wrote:
> Does this actually work? "true" is not a property of Window (or a global
> variable), and it's not defined in test.html either.

Oops, right you are.

https://chromiumcodereview.appspot.com/10436015/diff/1/chrome/test/data/exten...
chrome/test/data/extensions/platform_apps/windows_api/test.js:16:
chrome.windows.create('test.html', {width: 128, height: 128},
On 2012/05/24 21:16:04, Mihai Parparita wrote:
> This needs to be updated to chrome.appWindow.create too.

Can you tell I didn't run the tests? >_>

[Mihai Parparita -not on Chrome, 2012-05-29 06:09:13]

LGTM

If this lands after https://chromiumcodereview.appspot.com/10456003/, maybe all
of the {}, function() {} dummy params can be removed?

https://chromiumcodereview.appspot.com/10436015/diff/6009/chrome/browser/ui/e...
File chrome/browser/ui/extensions/shell_window.cc (right):

https://chromiumcodereview.appspot.com/10436015/diff/6009/chrome/browser/ui/e...
chrome/browser/ui/extensions/shell_window.cc:79: // this should NOTREACHED().
NOTREACHED SGTM

[jeremya, 2012-05-30 01:10:47]

https://chromiumcodereview.appspot.com/10436015/diff/6009/chrome/browser/ui/e...
File chrome/browser/ui/extensions/shell_window.cc (right):

https://chromiumcodereview.appspot.com/10436015/diff/6009/chrome/browser/ui/e...
chrome/browser/ui/extensions/shell_window.cc:79: // this should NOTREACHED().
On 2012/05/29 06:09:13, Mihai Parparita wrote:
> NOTREACHED SGTM

Done.

[commit-bot: I haz the power, 2012-06-06 00:49:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/10436015/10001

[commit-bot: I haz the power, 2012-06-06 01:36:14]

Try job failure for 10436015-10001 (retry) on linux_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[jeremya, 2012-06-06 05:01:33]

Since shell windows are no longer accessible from the chrome.windows.* API, I've
removed the ExtensionWindowController that supported it. Could you take another
look, Mihai?

[Mihai Parparita -not on Chrome, 2012-06-06 20:58:43]

LGTM

(though we'll probably want to bring this back if the new windowing API should
operate on panels too)

https://chromiumcodereview.appspot.com/10436015/diff/16002/chrome/browser/ui/...
File chrome/browser/ui/extensions/shell_window.h (right):

https://chromiumcodereview.appspot.com/10436015/diff/16002/chrome/browser/ui/...
chrome/browser/ui/extensions/shell_window.h:113: virtual
ExtensionWindowController* GetExtensionWindowController() const
Can we remove this too?

[jeremya, 2012-06-06 23:50:06]

https://chromiumcodereview.appspot.com/10436015/diff/16002/chrome/browser/ui/...
File chrome/browser/ui/extensions/shell_window.h (right):

https://chromiumcodereview.appspot.com/10436015/diff/16002/chrome/browser/ui/...
chrome/browser/ui/extensions/shell_window.h:113: virtual
ExtensionWindowController* GetExtensionWindowController() const
On 2012/06/06 20:58:43, Mihai Parparita wrote:
> Can we remove this too?

It's required by EFD::Delegate, which we still need to implement (we just return
NULL though, since nothing actually calls it.)

[commit-bot: I haz the power, 2012-06-07 00:50:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/10436015/13004

[commit-bot: I haz the power, 2012-06-07 03:56:08]

Change committed as 140947