Issue 10423008: Fixed RegExp.prototype.toString.call bug not throwing TypeError when non RegExp object was passed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10423008: Fixed RegExp.prototype.toString.call bug not throwing TypeError when non RegExp object was passed. (Closed)

Created:
8 years, 7 months ago by ioseb

Modified:
8 years, 7 months ago

Reviewers:
Michael Starzinger (Google), Michael Starzinger, rossberg

CC:
v8-dev, rossberg, Michael Starzinger (Google)

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Fixed RegExp.prototype.toString.call bug not throwing TypeError when non RegExp object was passed. Bug report: http://code.google.com/p/v8/issues/detail?id=1981 BUG=1981 TEST=

Patch Set 1 #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	src/regexp.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	test/mjsunit/regexp.js	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM. I re-uploaded your CL (with minor adjustments) so that it is against the correct ...

8 years, 7 months ago (2012-05-23 20:27:27 UTC) #2

ioseb

8 years, 7 months ago (2012-05-23 20:31:39 UTC) #3

On 2012/05/23 20:27:27, Michael Starzinger wrote:
> LGTM. I re-uploaded your CL (with minor adjustments) so that it is against the
> correct base URL. Thanks for the contribution.
> 
> https://chromiumcodereview.appspot.com/10426005

You are welcome! 

Thanks for accepting it.

ioseb

Expand Messages | Collapse Messages