src/regexp.js - Issue 10423008: Fixed RegExp.prototype.toString.call bug not throwing TypeError when non RegExp object was passed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/regexp.js

Issue 10423008: Fixed RegExp.prototype.toString.call bug not throwing TypeError when non RegExp object was passed. (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/regexp.js

diff --git a/src/regexp.js b/src/regexp.js

index a574f62bf6a040b808bc40ea380f8a497f2261fe..44f8dd1234d9055afecd6be061839725b65f7d7d 100644

--- a/src/regexp.js

+++ b/src/regexp.js

@@ -278,6 +278,10 @@ function TrimRegExp(regexp) {

function RegExpToString() {

+ if (!IS_REGEXP(this)) {

+ throw MakeTypeError('incompatible_method_receiver',

+ ['RegExp.prototype.toString', this]);

+ }

var result = '/' + this.source + '/';

if (this.global) result += 'g';

if (this.ignoreCase) result += 'i';

« no previous file with comments | « no previous file | test/mjsunit/regexp.js » ('j') | no next file with comments »