Rename some chrome.exe exports: SetCommandLine --> SetCommandLine2, SetExperimentList --> SetExperi…

Rename some chrome.exe exports: SetCommandLine --> SetCommandLine2, SetExperimentList --> SetExperimentList2.

This will avoid mismatched parameter expectations when there is version shear, since their implementations were recently changed.
BUG=129390, 128541
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138935

[eroman, 2012-05-23 19:42:32]

Hopefully got everything this time!

[Sigurður Ásgeirsson, 2012-05-23 21:30:31]

http://codereview.chromium.org/10422019/diff/1/chrome/app/breakpad_field_tria...
File chrome/app/breakpad_field_trial_win.cc (right):

http://codereview.chromium.org/10422019/diff/1/chrome/app/breakpad_field_tria...
chrome/app/breakpad_field_trial_win.cc:15: extern "C" void __declspec(dllexport)
__cdecl SetExperimentList2(
Please add a comment here explaining that it's critical to change the name if
the signature of this function changes.

http://codereview.chromium.org/10422019/diff/1/chrome/app/breakpad_win.cc
File chrome/app/breakpad_win.cc (right):

http://codereview.chromium.org/10422019/diff/1/chrome/app/breakpad_win.cc#new...
chrome/app/breakpad_win.cc:154: extern "C" void __declspec(dllexport) __cdecl
SetCommandLine2(
Please add a comment here (and other places where these exports are perpetrated)
that it's critical to change the name when the arguments change.
This will protect against maintenance brittleness.

[Sigurður Ásgeirsson, 2012-05-23 21:32:20]

Please also make sure that the client-side code is safe against name changes.
The instances I looked at all had a NULL check, but I'm not sure I looked at all
the instances.
If the client-side code does not walk away when the export is not found, we're
no better off, as it'll either invoke NULL or crash and burn in some other weird
and wonderful way.

[eroman, 2012-05-23 21:45:13]

@siggi: The callers of these functions already checks for NULL, so this should
be sufficient.

Changing reviewer to @cpu, since I need OWNERS approval.

http://codereview.chromium.org/10422019/diff/1/chrome/app/breakpad_field_tria...
File chrome/app/breakpad_field_trial_win.cc (right):

http://codereview.chromium.org/10422019/diff/1/chrome/app/breakpad_field_tria...
chrome/app/breakpad_field_trial_win.cc:15: extern "C" void __declspec(dllexport)
__cdecl SetExperimentList2(
On 2012/05/23 21:30:31, Sigurður Ásgeirsson wrote:
> Please add a comment here explaining that it's critical to change the name if
> the signature of this function changes.

Done.

http://codereview.chromium.org/10422019/diff/1/chrome/app/breakpad_win.cc
File chrome/app/breakpad_win.cc (right):

http://codereview.chromium.org/10422019/diff/1/chrome/app/breakpad_win.cc#new...
chrome/app/breakpad_win.cc:154: extern "C" void __declspec(dllexport) __cdecl
SetCommandLine2(
On 2012/05/23 21:30:31, Sigurður Ásgeirsson wrote:
> Please add a comment here (and other places where these exports are
perpetrated)
> that it's critical to change the name when the arguments change.
> This will protect against maintenance brittleness.

Done.

[cpu_(ooo_6.6-7.5), 2012-05-24 22:19:16]

lgtm

[commit-bot: I haz the power, 2012-05-24 22:23:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eroman@chromium.org/10422019/6001

[commit-bot: I haz the power, 2012-05-25 00:08:12]

Change committed as 138935