Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5114)

Unified Diff: chrome/common/child_process_logging_win.cc

Issue 10422019: Rename some chrome.exe exports: SetCommandLine --> SetCommandLine2, SetExperimentList --> SetExperi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add comments on why the new name Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/breakpad_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/child_process_logging_win.cc
diff --git a/chrome/common/child_process_logging_win.cc b/chrome/common/child_process_logging_win.cc
index 19b3f7881867e1e3184bef862ccd361313621ecc..36a37d41eabc25f3e9e53220e4fab5ce37de1d0f 100644
--- a/chrome/common/child_process_logging_win.cc
+++ b/chrome/common/child_process_logging_win.cc
@@ -48,11 +48,11 @@ typedef void (__cdecl *MainSetPrinterInfo)(const wchar_t*);
typedef void (__cdecl *MainSetNumberOfViews)(int);
// exported in breakpad_win.cc:
-// void __declspec(dllexport) __cdecl SetCommandLine
+// void __declspec(dllexport) __cdecl SetCommandLine2
typedef void (__cdecl *MainSetCommandLine)(const wchar_t**, size_t);
// exported in breakpad_field_trial_win.cc:
-// void __declspec(dllexport) __cdecl SetExperimentList
+// void __declspec(dllexport) __cdecl SetExperimentList2
typedef void (__cdecl *MainSetExperimentList)(const wchar_t**, size_t);
// Copied from breakpad_win.cc.
@@ -199,7 +199,7 @@ void SetCommandLine(const CommandLine* command_line) {
if (!exe_module)
return;
set_command_line = reinterpret_cast<MainSetCommandLine>(
- GetProcAddress(exe_module, "SetCommandLine"));
+ GetProcAddress(exe_module, "SetCommandLine2"));
if (!set_command_line)
return;
}
@@ -217,7 +217,7 @@ void SetExperimentList(const std::vector<string16>& state) {
if (!exe_module)
return;
set_experiment_list = reinterpret_cast<MainSetExperimentList>(
- GetProcAddress(exe_module, "SetExperimentList"));
+ GetProcAddress(exe_module, "SetExperimentList2"));
if (!set_experiment_list)
return;
}
« no previous file with comments | « chrome/app/breakpad_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698