Issue 10421021: Make DownloadProtectionService not use BrowserList::GetLastActive() to load a link. Instead pass th…

Issue 10421021: Make DownloadProtectionService not use BrowserList::GetLastActive() to load a link. Instead pass th… (Closed)

Created:
8 years, 7 months ago by Ben Goodger (Google)

Modified:
8 years, 7 months ago

Reviewers:
asanka

CC:
chromium-reviews, asanka, Randy Smith (Not in Mondays), rdsmith+dwatch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make DownloadProtectionService not use BrowserList::GetLastActive() to load a link. Instead pass the relevant PageNavigator through to it. http://crbug.com/129187 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138483

Patch Set 1 : #

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -28 lines)			Patch
M	chrome/browser/download/download_shelf_context_menu.h	View		3 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/download/download_shelf_context_menu.cc	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/download_protection_service.cc	View		1 chunk	+8 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_item_controller.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_item_controller.mm	View		3 chunks	+8 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_shelf_controller.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/download/download_shelf_controller.mm	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/download/download_item_gtk.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/download/download_shelf_context_menu_gtk.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/download/download_shelf_context_menu_gtk.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
MM	chrome/browser/ui/gtk/download/download_shelf_gtk.h	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/gtk/download/download_shelf_gtk.cc	View	1	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/download/download_item_view.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/download/download_shelf_context_menu_view.h	View		2 chunks	+6 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/download/download_shelf_context_menu_view.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/download/download_shelf_view.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/download/download_shelf_view.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ben@chromium.org/10421021/8008

8 years, 7 months ago (2012-05-23 03:08:35 UTC) #3

commit-bot: I haz the power

8 years, 7 months ago (2012-05-23 03:08:42 UTC) #4

Can't process patch for file
chrome/browser/ui/gtk/download/download_shelf_gtk.h.
Failed to parse svn properties: Deleted: svn:mergeinfo, []

Expand Messages | Collapse Messages