chrome/browser/safe_browsing/download_protection_service.cc - Issue 10421021: Make DownloadProtectionService not use BrowserList::GetLastActive() to load a link. Instead pass th…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/download_protection_service.cc

Issue 10421021: Make DownloadProtectionService not use BrowserList::GetLastActive() to load a link. Instead pass th… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/download_protection_service.h ('k') | chrome/browser/ui/cocoa/download/download_item_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/download_protection_service.cc

===================================================================

--- chrome/browser/safe_browsing/download_protection_service.cc (revision 138377)

+++ chrome/browser/safe_browsing/download_protection_service.cc (working copy)

@@ -865,13 +865,14 @@

}

void DownloadProtectionService::ShowDetailsForDownload(

- const DownloadProtectionService::DownloadInfo& info) {

- Browser* browser = BrowserList::GetLastActive();

- DCHECK(browser && browser->is_type_tabbed());

- content::OpenURLParams params(GURL(chrome::kDownloadScanningLearnMoreURL),

- content::Referrer(), NEW_FOREGROUND_TAB,

- content::PAGE_TRANSITION_TYPED, false);

- browser->OpenURL(params);

+ const DownloadProtectionService::DownloadInfo& info,

+ content::PageNavigator* navigator) {

+ navigator->OpenURL(

+ content::OpenURLParams(GURL(chrome::kDownloadScanningLearnMoreURL),

+ content::Referrer(),

+ NEW_FOREGROUND_TAB,

+ content::PAGE_TRANSITION_LINK,

+ false));

}

namespace {