Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 10417013: Show fixed arrow for uber tray bubble if shelf alignment is vertical. (Closed)

Created:
8 years, 7 months ago by jennyz
Modified:
8 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Show fixed arrow for uber tray bubble if shelf alignment is vertical. BUG=127577 TEST=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M ash/system/tray/system_tray.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M ash/system/tray/system_tray_bubble.h View 2 chunks +2 lines, -1 line 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jennyz
8 years, 7 months ago (2012-05-21 18:10:00 UTC) #1
sadrul
LGTM
8 years, 7 months ago (2012-05-22 17:04:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jennyz@chromium.org/10417013/1
8 years, 7 months ago (2012-05-22 17:35:07 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 18:57:25 UTC) #4
Try job failure for 10417013-1 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698