Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2923)

Unified Diff: ash/system/tray/system_tray_bubble.cc

Issue 10417013: Show fixed arrow for uber tray bubble if shelf alignment is vertical. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/tray/system_tray_bubble.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/tray/system_tray_bubble.cc
diff --git a/ash/system/tray/system_tray_bubble.cc b/ash/system/tray/system_tray_bubble.cc
index 26a28b41ca23b7ef6e3321914a75dfecdba3dd1a..8f6609c1dda5bd86bf00d0d5d1fdad6683f974fe 100644
--- a/ash/system/tray/system_tray_bubble.cc
+++ b/ash/system/tray/system_tray_bubble.cc
@@ -43,6 +43,7 @@ const int kSystemTrayBubbleVerticalInset = 1;
const int kArrowHeight = 10;
const int kArrowWidth = 20;
const int kArrowPaddingFromRight = 20;
+const int kArrowPaddingFromBottom = 17;
const int kMinArrowOffset = 12;
const int kAnimationDurationForPopupMS = 200;
@@ -350,12 +351,16 @@ void SystemTrayBubbleView::OnMouseExited(const views::MouseEvent& event) {
// SystemTrayBubble::InitParams
SystemTrayBubble::InitParams::InitParams(
- SystemTrayBubble::AnchorType anchor_type)
+ SystemTrayBubble::AnchorType anchor_type,
+ ShelfAlignment shelf_alignment)
: anchor(NULL),
anchor_type(anchor_type),
can_activate(false),
login_status(ash::user::LOGGED_IN_NONE),
- arrow_offset(kArrowPaddingFromRight + kArrowWidth / 2) {
+ arrow_offset(
+ (shelf_alignment == SHELF_ALIGNMENT_BOTTOM ?
+ kArrowPaddingFromRight : kArrowPaddingFromBottom)
+ + kArrowWidth / 2) {
}
// SystemTrayBubble
« no previous file with comments | « ash/system/tray/system_tray_bubble.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698