Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 10416027: Remove virtual keyboard support from ui/views/ime/. (Closed)

Created:
8 years, 7 months ago by Yusuke Sato
Modified:
8 years, 7 months ago
Reviewers:
Peng, sky
CC:
chromium-reviews, tfarina, James Su, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove virtual keyboard support from ui/views/ime/. This CL depends on https://chromiumcodereview.appspot.com/10399046 BUG=128295 TEST=try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138447

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -112 lines) Patch
M ui/views/ime/input_method_base.cc View 4 chunks +0 lines, -13 lines 0 comments Download
D ui/views/ime/text_input_type_tracker.h View 1 chunk +0 lines, -60 lines 0 comments Download
D ui/views/ime/text_input_type_tracker.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M ui/views/views.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yusuke Sato
8 years, 7 months ago (2012-05-22 06:25:58 UTC) #1
Peng
On 2012/05/22 06:25:58, Yusuke Sato wrote: lgtm
8 years, 7 months ago (2012-05-22 12:45:37 UTC) #2
Yusuke Sato
+sky
8 years, 7 months ago (2012-05-22 22:52:33 UTC) #3
sky
LGTM
8 years, 7 months ago (2012-05-23 00:00:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10416027/1
8 years, 7 months ago (2012-05-23 04:20:12 UTC) #5
commit-bot: I haz the power
Try job failure for 10416027-1 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-23 06:43:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10416027/1
8 years, 7 months ago (2012-05-23 06:52:09 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 08:05:17 UTC) #8
Try job failure for 10416027-1 (retry) on linux_rel for steps "base_unittests,
browser_tests, net_unittests".
It's a second try, previously, steps "base_unittests, browser_tests,
net_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

Powered by Google App Engine
This is Rietveld 408576698