Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 10399046: Remove virtual keyboard support. (Closed)

Created:
8 years, 7 months ago by Yusuke Sato
Modified:
8 years, 7 months ago
CC:
chromium-reviews, jochen+watch-content_chromium.org, MAD, mihaip-chromium-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, derat+watch_chromium.org, Ilya Sherman, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org, James Su, stevenjb+watch_chromium.org, jar (doing other things), davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Remove virtual keyboard support: 1. common.gypi: use_virtual_keyboard define 2. Any code controlled by that define 3. chrome/browser/ui/virtual_keyboard/* 4. chrome/browser/resources/keyboard/* 5. experimental extension APIs for virtual keyboard No user-visible changes. BUG=128295 TEST=try Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138223

Patch Set 1 : review #

Patch Set 2 : fix browser_tests #

Patch Set 3 : rebase, update js docs #

Patch Set 4 : rebase #

Patch Set 5 : final rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -6777 lines) Patch
M build/common.gypi View 1 2 3 4 8 chunks +4 lines, -18 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller.h View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_base_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.h View 1 2 3 4 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/ibus_controller_impl.cc View 1 2 3 4 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_descriptor.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_descriptor_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_whitelist_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_methods.txt View 3 chunks +49 lines, -50 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_ibus_controller.h View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/browser/chromeos/input_method/virtual_keyboard_selector.h View 1 chunk +0 lines, -155 lines 0 comments Download
D chrome/browser/chromeos/input_method/virtual_keyboard_selector.cc View 1 chunk +0 lines, -175 lines 0 comments Download
D chrome/browser/chromeos/input_method/virtual_keyboard_selector_unittest.cc View 1 chunk +0 lines, -739 lines 0 comments Download
M chrome/browser/chromeos/input_method/xkeyboard.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/input_method/xkeyboard_unittest.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.cc View 1 2 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 1 2 3 4 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 3 chunks +0 lines, -32 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 1 2 3 4 4 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/extensions/extension_input_api.h View 1 chunk +0 lines, -54 lines 0 comments Download
M chrome/browser/extensions/extension_input_api.cc View 3 chunks +0 lines, -95 lines 0 comments Download
D chrome/browser/extensions/extension_input_ui_api.h View 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/extensions/extension_input_ui_api.cc View 1 chunk +0 lines, -239 lines 0 comments Download
M chrome/browser/extensions/extension_input_ui_apitest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/extensions/extension_override_apitest.cc View 1 2 3 4 2 chunks +0 lines, -41 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 2 3 4 3 chunks +0 lines, -23 lines 0 comments Download
M chrome/browser/metrics/metrics_service_browsertest.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M chrome/browser/renderer_host/render_process_host_chrome_browsertest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/component_extension_resources.grd View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/browser/resources/keyboard/chevron.svg View 1 chunk +0 lines, -9 lines 0 comments Download
D chrome/browser/resources/keyboard/common.js View 1 chunk +0 lines, -972 lines 0 comments Download
D chrome/browser/resources/keyboard/del.svg View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/resources/keyboard/ime.js View 1 chunk +0 lines, -282 lines 0 comments Download
D chrome/browser/resources/keyboard/index.html View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/browser/resources/keyboard/keyboard.svg View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/resources/keyboard/layout_fr.js View 1 chunk +0 lines, -228 lines 0 comments Download
D chrome/browser/resources/keyboard/layout_handwriting_vk.js View 1 chunk +0 lines, -233 lines 0 comments Download
D chrome/browser/resources/keyboard/layout_us.js View 1 chunk +0 lines, -75 lines 0 comments Download
D chrome/browser/resources/keyboard/main.css View 1 chunk +0 lines, -223 lines 0 comments Download
D chrome/browser/resources/keyboard/main.js View 1 chunk +0 lines, -252 lines 0 comments Download
D chrome/browser/resources/keyboard/manifest.json View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/resources/keyboard/mic.svg View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/resources/keyboard/ret.svg View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/resources/keyboard/shift.svg View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/resources/keyboard/shift-down.svg View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/resources/keyboard/tab.svg View 1 chunk +0 lines, -14 lines 0 comments Download
D chrome/browser/resources/options2/chromeos/virtual_keyboard.css View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/resources/options2/chromeos/virtual_keyboard.html View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/resources/options2/chromeos/virtual_keyboard.js View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/resources/options2/chromeos/virtual_keyboard_list.js View 1 chunk +0 lines, -144 lines 0 comments Download
M chrome/browser/resources/options2/language_options.html View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/options2/language_options.js View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/options2/options.js View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/options2/options_bundle.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.cc View 1 2 3 4 2 chunks +0 lines, -9 lines 0 comments Download
D chrome/browser/ui/virtual_keyboard/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc View 1 chunk +0 lines, -536 lines 0 comments Download
D chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager_browsertest.cc View 1 chunk +0 lines, -98 lines 0 comments Download
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 2 chunks +0 lines, -8 lines 0 comments Download
D chrome/browser/ui/webui/keyboard_ui.h View 1 chunk +0 lines, -40 lines 0 comments Download
D chrome/browser/ui/webui/keyboard_ui.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/cros_language_options_handler2.cc View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/virtual_keyboard_manager_handler2.h View 1 chunk +0 lines, -80 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/virtual_keyboard_manager_handler2.cc View 1 chunk +0 lines, -234 lines 0 comments Download
D chrome/browser/ui/webui/options2/chromeos/virtual_keyboard_manager_handler2_unittest.cc View 1 chunk +0 lines, -552 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 chunks +0 lines, -16 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 3 chunks +0 lines, -15 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 chunks +0 lines, -19 lines 0 comments Download
M chrome/common/chrome_notification_types.h View 1 2 3 4 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/common/extensions/api/experimental_input_ui.json View 1 chunk +0 lines, -146 lines 0 comments Download
M chrome/common/extensions/api/experimental_input_virtual_keyboard.json View 1 chunk +0 lines, -79 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/docs/js/api_page_generator.js View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 4 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 2 chunks +1 line, -5 lines 0 comments Download
D chrome/test/data/extensions/api_test/input_ui/chromeos_virtual_keyboard/manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/input_ui/chromeos_virtual_keyboard/test.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/input_ui/chromeos_virtual_keyboard/test.js View 1 chunk +0 lines, -16 lines 0 comments Download
D chrome/test/data/extensions/api_test/input_ui/other/manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/input_ui/other/test.html View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/input_ui/other/test.js View 1 chunk +0 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 1 3 chunks +0 lines, -12 lines 0 comments Download
M ui/base/ime/input_method_base.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Yusuke Sato
8 years, 7 months ago (2012-05-17 01:40:18 UTC) #1
hashimoto
lgtm
8 years, 7 months ago (2012-05-17 05:00:06 UTC) #2
Yusuke Sato
+bryeung Bryan, I'm going to remove chrome.input APIs except chrome.experimental.input.ime and sendKeyboardEvent. This means chrome.experimental.input.ui.* ...
8 years, 7 months ago (2012-05-17 05:12:42 UTC) #3
bryeung
+penghuang (as he wrote the chrome.experimental.input.ui.* APIs) On Thu, May 17, 2012 at 1:12 AM, ...
8 years, 7 months ago (2012-05-17 15:44:35 UTC) #4
Yusuke Sato
Thanks Bryan. +ben, +jar, +mpcomplete, +avayvod, +jhawkins Could you do an OWNERS review for the ...
8 years, 7 months ago (2012-05-18 10:27:10 UTC) #5
whywhat
chromeos: lgtm
8 years, 7 months ago (2012-05-18 10:34:18 UTC) #6
Ben Goodger (Google)
Great! Thanks for cleaning this up :-) LGTM
8 years, 7 months ago (2012-05-18 15:56:28 UTC) #7
Matt Perry
lgtm
8 years, 7 months ago (2012-05-18 18:55:08 UTC) #8
Yusuke Sato
jhawkins: ping?
8 years, 7 months ago (2012-05-21 04:12:25 UTC) #9
James Hawkins
LGTM. This CL should have been broken up and submitted in pieces.
8 years, 7 months ago (2012-05-21 15:17:30 UTC) #10
Yusuke Sato
On 2012/05/21 15:17:30, James Hawkins wrote: > LGTM. This CL should have been broken up ...
8 years, 7 months ago (2012-05-22 04:29:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10399046/19003
8 years, 7 months ago (2012-05-22 04:31:08 UTC) #12
commit-bot: I haz the power
Presubmit check for 10399046-19003 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-22 04:32:08 UTC) #13
Yusuke Sato
8 years, 7 months ago (2012-05-22 05:50:44 UTC) #14
the presubmit error is not related to this CL. manually submitting the change..

On 2012/05/22 04:32:08, I haz the power (commit-bot) wrote:
> Presubmit check for 10399046-19003 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> 
> ** Presubmit Messages **
> See the JavaScript style guide at
> http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
> and if you have any feedback about the JavaScript PRESUBMIT check, contact
> mailto:tbreisacher@chromium.org
> 
> ** Presubmit Warnings **
> Found JavaScript style violations in
> chrome/common/extensions/docs/js/api_page_generator.js:
>   line 171: Use $('id'), from chrome://resources/js/util.js, instead of
> document.getElementById('id'))
>     document.getElementById('static').innerHTML = overviewContent;
>     ^^^^^^^^^^^^^^^^^^^^^^^
>   line 85: E0010: Missing semicolon at end of line
> ]
> ^
>   line 128: E0220: No docs found for member 'Array.prototype.select'
> Array.prototype.select = function(f) {
> ^^^^^^^^^^^^^^^^^^^^^^
>   line 133: E0011: Missing semicolon after function assigned to a variable
> }
> ^
>   line 239: E0210: Missing docs for parameter: "url"
> function fetchContent(url, onSuccess, onError) {
>                                              ^^
>   line 239: E0210: Missing docs for parameter: "onSuccess"
> function fetchContent(url, onSuccess, onError) {
>                                              ^^
>   line 239: E0210: Missing docs for parameter: "onError"
> function fetchContent(url, onSuccess, onError) {
>                                              ^^
>   line 258: E0002: Missing space before "{"
>     xhr.onreadystatechange = function(){
>                                        ^
>   line 273: E0002: Missing space before "("
>   } catch(e) {
>          ^
>   line 363: E0010: Missing semicolon at end of line
>     var n = nodes[i]
>                    ^
>   line 409: E0002: Missing space before "("
>   while(n = results.iterateNext()) {
>        ^
> 
> Presubmit checks took 8.0s to calculate.

Powered by Google App Engine
This is Rietveld 408576698