Cleanup: Add test fixture for SystemMonitorTest to remove some redundant code.

Cleanup: Add test fixture for SystemMonitorTest to remove some redundant code.

BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138344

[willchan no longer on Chromium, 2012-05-21 23:51:34]

https://chromiumcodereview.appspot.com/10414032/diff/1/base/system_monitor/sy...
File base/system_monitor/system_monitor_unittest.cc (right):

https://chromiumcodereview.appspot.com/10414032/diff/1/base/system_monitor/sy...
base/system_monitor/system_monitor_unittest.cc:53: public:
These don't have to be public. TEST_Fs will call them in a protected manner
anyway.

https://chromiumcodereview.appspot.com/10414032/diff/1/base/system_monitor/sy...
base/system_monitor/system_monitor_unittest.cc:60:
SystemMonitor::AllocateSystemIOPorts();
If you wanted, you could move this into the constructor body. Meh.

[willchan no longer on Chromium, 2012-05-21 23:51:38]

lgtm

[Lei Zhang, 2012-05-21 23:58:10]

https://chromiumcodereview.appspot.com/10414032/diff/1/base/system_monitor/sy...
File base/system_monitor/system_monitor_unittest.cc (right):

https://chromiumcodereview.appspot.com/10414032/diff/1/base/system_monitor/sy...
base/system_monitor/system_monitor_unittest.cc:53: public:
On 2012/05/21 23:51:35, willchan wrote:
> These don't have to be public. TEST_Fs will call them in a protected manner
> anyway.

Done.

https://chromiumcodereview.appspot.com/10414032/diff/1/base/system_monitor/sy...
base/system_monitor/system_monitor_unittest.cc:60:
SystemMonitor::AllocateSystemIOPorts();
On 2012/05/21 23:51:35, willchan wrote:
> If you wanted, you could move this into the constructor body. Meh.

Done.

[commit-bot: I haz the power, 2012-05-21 23:58:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/10414032/10001

[commit-bot: I haz the power, 2012-05-22 00:30:50]

Try job failure for 10414032-10001 (retry) on mac_rel for step "base_unittests".
It's a second try, previously, step "base_unittests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Lei Zhang, 2012-05-22 02:55:45]

On 2012/05/22 00:30:50, I haz the power (commit-bot) wrote:
> Try job failure for 10414032-10001 (retry) on mac_rel for step
"base_unittests".
> It's a second try, previously, step "base_unittests" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

In patch set 3, I made |system_monitor_| into a scoped_ptr, so we can call
SystemMonitor::AllocateSystemIOPorts on Mac before |system_monitor_| gets
created.

[commit-bot: I haz the power, 2012-05-22 02:56:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/10414032/4005

[commit-bot: I haz the power, 2012-05-22 09:18:23]

Try job failure for 10414032-4005 (retry) (retry) (retry) on win_rel for step
"sync_unit_tests".
It's a second try, previously, step "sync_unit_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...