Cleanup: Add test fixture for SystemMonitorTest to remove some redundant code.

base/system_monitor/system_monitor_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/system_monitor/system_monitor.h"
 
 #include "base/file_path.h"
 #include "base/message_loop.h"
 #include "base/test/mock_devices_changed_observer.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace base {
 
+namespace {
+
 class PowerTest : public SystemMonitor::PowerObserver {
  public:
   PowerTest()
       : battery_(false),
         power_state_changes_(0),
         suspends_(0),
         resumes_(0) {
   }
 
   // PowerObserver callbacks.
@@ skipping 15 matching lines @@
   int suspends() { return suspends_; }
   int resumes() { return resumes_; }
 
  private:
   bool battery_;   // Do we currently think we're on battery power.
   int power_state_changes_;  // Count of OnPowerStateChange notifications.
   int suspends_;  // Count of OnSuspend notifications.
   int resumes_;  // Count of OnResume notifications.
 };
 
-TEST(SystemMonitor, PowerNotifications) {
+class SystemMonitorTest : public testing::Test {
+ public:

[willchan no longer on Chromium, 2012/05/21 23:51:35]

These don't have to be public. TEST_Fs will call them in a protected manner
anyway.

[Lei Zhang, 2012/05/21 23:58:10]

Done.

+  SystemMonitorTest() {}
+  virtual ~SystemMonitorTest() {}
+
+ protected:
+  virtual void SetUp() OVERRIDE {
+#if defined(OS_MACOSX)
+    SystemMonitor::AllocateSystemIOPorts();

[willchan no longer on Chromium, 2012/05/21 23:51:35]

If you wanted, you could move this into the constructor body. Meh.

[Lei Zhang, 2012/05/21 23:58:10]

Done.

+#endif
+  }
+
+  MessageLoop message_loop_;
+  SystemMonitor system_monitor_;
+
+  DISALLOW_COPY_AND_ASSIGN(SystemMonitorTest);
+};
+
+TEST_F(SystemMonitorTest, PowerNotifications) {
   const int kObservers = 5;
 
-  // Initialize a message loop for this to run on.
-  MessageLoop loop;
-
-#if defined(OS_MACOSX)
-  SystemMonitor::AllocateSystemIOPorts();
-#endif
-
-  SystemMonitor system_monitor;
   PowerTest test[kObservers];
   for (int index = 0; index < kObservers; ++index)
-    system_monitor.AddPowerObserver(&test[index]);
+    system_monitor_.AddPowerObserver(&test[index]);
 
   // Send a bunch of power changes.  Since the battery power hasn't
   // actually changed, we shouldn't get notifications.
   for (int index = 0; index < 5; index++) {
-    system_monitor.ProcessPowerMessage(SystemMonitor::POWER_STATE_EVENT);
+    system_monitor_.ProcessPowerMessage(SystemMonitor::POWER_STATE_EVENT);
     EXPECT_EQ(test[0].power_state_changes(), 0);
   }
 
   // Sending resume when not suspended should have no effect.
-  system_monitor.ProcessPowerMessage(SystemMonitor::RESUME_EVENT);
-  loop.RunAllPending();
+  system_monitor_.ProcessPowerMessage(SystemMonitor::RESUME_EVENT);
+  message_loop_.RunAllPending();
   EXPECT_EQ(test[0].resumes(), 0);
 
   // Pretend we suspended.
-  system_monitor.ProcessPowerMessage(SystemMonitor::SUSPEND_EVENT);
-  loop.RunAllPending();
+  system_monitor_.ProcessPowerMessage(SystemMonitor::SUSPEND_EVENT);
+  message_loop_.RunAllPending();
   EXPECT_EQ(test[0].suspends(), 1);
 
   // Send a second suspend notification.  This should be suppressed.
-  system_monitor.ProcessPowerMessage(SystemMonitor::SUSPEND_EVENT);
-  loop.RunAllPending();
+  system_monitor_.ProcessPowerMessage(SystemMonitor::SUSPEND_EVENT);
+  message_loop_.RunAllPending();
   EXPECT_EQ(test[0].suspends(), 1);
 
   // Pretend we were awakened.
-  system_monitor.ProcessPowerMessage(SystemMonitor::RESUME_EVENT);
-  loop.RunAllPending();
+  system_monitor_.ProcessPowerMessage(SystemMonitor::RESUME_EVENT);
+  message_loop_.RunAllPending();
   EXPECT_EQ(test[0].resumes(), 1);
 
   // Send a duplicate resume notification.  This should be suppressed.
-  system_monitor.ProcessPowerMessage(SystemMonitor::RESUME_EVENT);
-  loop.RunAllPending();
+  system_monitor_.ProcessPowerMessage(SystemMonitor::RESUME_EVENT);
+  message_loop_.RunAllPending();
   EXPECT_EQ(test[0].resumes(), 1);
 }
 
-TEST(SystemMonitor, DeviceChangeNotifications) {
+TEST_F(SystemMonitorTest, DeviceChangeNotifications) {
   const int kObservers = 5;
 
-  // Initialize a message loop for this to run on.
-  MessageLoop loop;
-
-#if defined(OS_MACOSX)
-  SystemMonitor::AllocateSystemIOPorts();
-#endif
-
   testing::Sequence mock_sequencer[kObservers];
-  SystemMonitor system_monitor;
   MockDevicesChangedObserver observers[kObservers];
   for (int index = 0; index < kObservers; ++index) {
-    system_monitor.AddDevicesChangedObserver(&observers[index]);
+    system_monitor_.AddDevicesChangedObserver(&observers[index]);
 
     EXPECT_CALL(observers[index], OnDevicesChanged())
         .Times(3)
         .InSequence(mock_sequencer[index]);
     EXPECT_CALL(observers[index], OnMediaDeviceAttached(1, "media device",
                                                         testing::_))
         .InSequence(mock_sequencer[index]);
     EXPECT_CALL(observers[index], OnMediaDeviceDetached(1))
         .InSequence(mock_sequencer[index]);
     EXPECT_CALL(observers[index], OnMediaDeviceDetached(2))
         .InSequence(mock_sequencer[index]);
   }
 
-  system_monitor.ProcessDevicesChanged();
-  loop.RunAllPending();
+  system_monitor_.ProcessDevicesChanged();
+  message_loop_.RunAllPending();
 
-  system_monitor.ProcessDevicesChanged();
-  system_monitor.ProcessDevicesChanged();
-  loop.RunAllPending();
+  system_monitor_.ProcessDevicesChanged();
+  system_monitor_.ProcessDevicesChanged();
+  message_loop_.RunAllPending();
 
-  system_monitor.ProcessMediaDeviceAttached(
+  system_monitor_.ProcessMediaDeviceAttached(
       1, "media device", FilePath(FILE_PATH_LITERAL("path")));
-  loop.RunAllPending();
+  message_loop_.RunAllPending();
 
-  system_monitor.ProcessMediaDeviceDetached(1);
-  system_monitor.ProcessMediaDeviceDetached(2);
-  loop.RunAllPending();
+  system_monitor_.ProcessMediaDeviceDetached(1);
+  system_monitor_.ProcessMediaDeviceDetached(2);
+  message_loop_.RunAllPending();
 }
 
-TEST(SystemMonitor, GetAttachedMediaDevicesEmpty) {
-  // Initialize a message loop for this to run on.
-  MessageLoop loop;
-
-#if defined(OS_MACOSX)
-  SystemMonitor::AllocateSystemIOPorts();
-#endif
-
-  SystemMonitor system_monitor;
-
+TEST_F(SystemMonitorTest, GetAttachedMediaDevicesEmpty) {
   scoped_ptr<std::vector<SystemMonitor::MediaDeviceInfo> > devices;
-  devices.reset(system_monitor.GetAttachedMediaDevices());
+  devices.reset(system_monitor_.GetAttachedMediaDevices());
   EXPECT_EQ(0U, devices->size());
 }
 
-TEST(SystemMonitor, GetAttachedMediaDevicesAttachDetach) {
-  // Initialize a message loop for this to run on.
-  MessageLoop loop;
-
-#if defined(OS_MACOSX)
-  SystemMonitor::AllocateSystemIOPorts();
-#endif
-
-  SystemMonitor system_monitor;
-
+TEST_F(SystemMonitorTest, GetAttachedMediaDevicesAttachDetach) {
   const SystemMonitor::DeviceIdType kDeviceId1 = 42;
   const char kDeviceName1[] = "test";
   const FilePath kDevicePath1(FILE_PATH_LITERAL("/testfoo"));
-  system_monitor.ProcessMediaDeviceAttached(kDeviceId1,
-                                            kDeviceName1,
-                                            kDevicePath1);
-  loop.RunAllPending();
+  system_monitor_.ProcessMediaDeviceAttached(kDeviceId1,
+                                             kDeviceName1,
+                                             kDevicePath1);
+  message_loop_.RunAllPending();
   scoped_ptr<std::vector<SystemMonitor::MediaDeviceInfo> > devices;
-  devices.reset(system_monitor.GetAttachedMediaDevices());
+  devices.reset(system_monitor_.GetAttachedMediaDevices());
   ASSERT_EQ(1U, devices->size());
   EXPECT_EQ(kDeviceId1, (*devices)[0].a);
   EXPECT_EQ(kDeviceName1, (*devices)[0].b);
   EXPECT_EQ(kDevicePath1, (*devices)[0].c);
 
   const SystemMonitor::DeviceIdType kDeviceId2 = 44;
   const char kDeviceName2[] = "test2";
   const FilePath kDevicePath2(FILE_PATH_LITERAL("/testbar"));
-  system_monitor.ProcessMediaDeviceAttached(kDeviceId2,
-                                            kDeviceName2,
-                                            kDevicePath2);
-  loop.RunAllPending();
-  devices.reset(system_monitor.GetAttachedMediaDevices());
+  system_monitor_.ProcessMediaDeviceAttached(kDeviceId2,
+                                             kDeviceName2,
+                                             kDevicePath2);
+  message_loop_.RunAllPending();
+  devices.reset(system_monitor_.GetAttachedMediaDevices());
   ASSERT_EQ(2U, devices->size());
   EXPECT_EQ(kDeviceId1, (*devices)[0].a);
   EXPECT_EQ(kDeviceName1, (*devices)[0].b);
   EXPECT_EQ(kDevicePath1, (*devices)[0].c);
   EXPECT_EQ(kDeviceId2, (*devices)[1].a);
   EXPECT_EQ(kDeviceName2, (*devices)[1].b);
   EXPECT_EQ(kDevicePath2, (*devices)[1].c);
 
-  system_monitor.ProcessMediaDeviceDetached(kDeviceId1);
-  loop.RunAllPending();
-  devices.reset(system_monitor.GetAttachedMediaDevices());
+  system_monitor_.ProcessMediaDeviceDetached(kDeviceId1);
+  message_loop_.RunAllPending();
+  devices.reset(system_monitor_.GetAttachedMediaDevices());
   ASSERT_EQ(1U, devices->size());
   EXPECT_EQ(kDeviceId2, (*devices)[0].a);
   EXPECT_EQ(kDeviceName2, (*devices)[0].b);
   EXPECT_EQ(kDevicePath2, (*devices)[0].c);
 
-  system_monitor.ProcessMediaDeviceDetached(kDeviceId2);
-  loop.RunAllPending();
-  devices.reset(system_monitor.GetAttachedMediaDevices());
+  system_monitor_.ProcessMediaDeviceDetached(kDeviceId2);
+  message_loop_.RunAllPending();
+  devices.reset(system_monitor_.GetAttachedMediaDevices());
   EXPECT_EQ(0U, devices->size());
 }
 
-TEST(SystemMonitor, PowerRequirements) {
+TEST_F(SystemMonitorTest, PowerRequirements) {
 #if defined(OS_WIN)
-  MessageLoop loop;
-  SystemMonitor system_monitor;
-  ASSERT_EQ(0, system_monitor.GetPowerRequirementsCountForTest());
+  ASSERT_EQ(0, system_monitor_.GetPowerRequirementsCountForTest());
 
-  system_monitor.BeginPowerRequirement(SystemMonitor::TEST_REQUIRED, "foo");
-  ASSERT_EQ(1, system_monitor.GetPowerRequirementsCountForTest());
+  system_monitor_.BeginPowerRequirement(SystemMonitor::TEST_REQUIRED, "foo");
+  ASSERT_EQ(1, system_monitor_.GetPowerRequirementsCountForTest());
 
-  system_monitor.BeginPowerRequirement(SystemMonitor::TEST_REQUIRED, "bar");
-  ASSERT_EQ(2, system_monitor.GetPowerRequirementsCountForTest());
+  system_monitor_.BeginPowerRequirement(SystemMonitor::TEST_REQUIRED, "bar");
+  ASSERT_EQ(2, system_monitor_.GetPowerRequirementsCountForTest());
 
   // A second identical request should not increase the request count.
-  system_monitor.BeginPowerRequirement(SystemMonitor::TEST_REQUIRED, "bar");
-  ASSERT_EQ(2, system_monitor.GetPowerRequirementsCountForTest());
+  system_monitor_.BeginPowerRequirement(SystemMonitor::TEST_REQUIRED, "bar");
+  ASSERT_EQ(2, system_monitor_.GetPowerRequirementsCountForTest());
 
-  system_monitor.EndPowerRequirement(SystemMonitor::TEST_REQUIRED, "foo");
-  ASSERT_EQ(1, system_monitor.GetPowerRequirementsCountForTest());
+  system_monitor_.EndPowerRequirement(SystemMonitor::TEST_REQUIRED, "foo");
+  ASSERT_EQ(1, system_monitor_.GetPowerRequirementsCountForTest());
 
   // The request count should not decrease until all identical requests end.
-  system_monitor.EndPowerRequirement(SystemMonitor::TEST_REQUIRED, "bar");
-  ASSERT_EQ(1, system_monitor.GetPowerRequirementsCountForTest());
+  system_monitor_.EndPowerRequirement(SystemMonitor::TEST_REQUIRED, "bar");
+  ASSERT_EQ(1, system_monitor_.GetPowerRequirementsCountForTest());
 
-  system_monitor.EndPowerRequirement(SystemMonitor::TEST_REQUIRED, "bar");
-  ASSERT_EQ(0, system_monitor.GetPowerRequirementsCountForTest());
+  system_monitor_.EndPowerRequirement(SystemMonitor::TEST_REQUIRED, "bar");
+  ASSERT_EQ(0, system_monitor_.GetPowerRequirementsCountForTest());
 #endif  // defined(OS_WIN)
 }
 
+}  // namespace
+
 }  // namespace base