Fix flakiness by removing GetLastActive from extension browser tests.

Fix flakiness by removing GetLastActive from extension browser tests.

BUG=108853
TEST=AppApiTest.* and ExtensionBrowserTest.* no longer flaky


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138503

[Charlie Reis, 2012-05-23 00:20:14]

Matt, can you review?  I'm abstracting out two helper functions into
ExtensionBrowserTest and removing flakiness from one of them.  (I also plan to
use both of them in IsolatedAppBrowserTest in my next CL.)

[Matt Perry, 2012-05-23 00:56:40]

lgtm

https://chromiumcodereview.appspot.com/10412047/diff/1001/chrome/browser/exte...
File chrome/browser/extensions/extension_browsertest.cc (right):

https://chromiumcodereview.appspot.com/10412047/diff/1001/chrome/browser/exte...
chrome/browser/extensions/extension_browsertest.cc:486: if
(newtab_process_should_equal_opener)
It seems weird to have this special check here. Can the calling code handle it
instead? Maybe with a small wrapper function?

[Charlie Reis, 2012-05-23 01:01:20]

https://chromiumcodereview.appspot.com/10412047/diff/1001/chrome/browser/exte...
File chrome/browser/extensions/extension_browsertest.cc (right):

https://chromiumcodereview.appspot.com/10412047/diff/1001/chrome/browser/exte...
chrome/browser/extensions/extension_browsertest.cc:486: if
(newtab_process_should_equal_opener)
On 2012/05/23 00:56:40, Matt Perry wrote:
> It seems weird to have this special check here. Can the calling code handle it
> instead? Maybe with a small wrapper function?

I suppose I could duplicate it into all the call sites, but it turns out to be
an interesting check at every call site.  Maybe one alternative is adding a
second out parameter for bool* opener_in_same_process.  Callers could then
easily do a check on it if they care.

[Matt Perry, 2012-05-23 01:02:19]

https://chromiumcodereview.appspot.com/10412047/diff/1001/chrome/browser/exte...
File chrome/browser/extensions/extension_browsertest.cc (right):

https://chromiumcodereview.appspot.com/10412047/diff/1001/chrome/browser/exte...
chrome/browser/extensions/extension_browsertest.cc:486: if
(newtab_process_should_equal_opener)
On 2012/05/23 01:01:20, creis wrote:
> On 2012/05/23 00:56:40, Matt Perry wrote:
> > It seems weird to have this special check here. Can the calling code handle
it
> > instead? Maybe with a small wrapper function?
> 
> I suppose I could duplicate it into all the call sites, but it turns out to be
> an interesting check at every call site.  Maybe one alternative is adding a
> second out parameter for bool* opener_in_same_process.  Callers could then
> easily do a check on it if they care.

OK, nevermind. Since all callers care, let's just leave it as is.

[commit-bot: I haz the power, 2012-05-23 14:59:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/creis@chromium.org/10412047/1001

[commit-bot: I haz the power, 2012-05-23 17:11:32]

Change committed as 138503