Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2047)

Unified Diff: chrome/browser/extensions/extension_browsertest.h

Issue 10412047: Fix flakiness by removing GetLastActive from extension browser tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Initial patch Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_browsertest.h
diff --git a/chrome/browser/extensions/extension_browsertest.h b/chrome/browser/extensions/extension_browsertest.h
index 19141d5c679832c26ada7a4cfffc7d054aed2e23..070123eda16dfbe2e02a051de29f1d18c8b6436b 100644
--- a/chrome/browser/extensions/extension_browsertest.h
+++ b/chrome/browser/extensions/extension_browsertest.h
@@ -16,6 +16,7 @@
#include "content/public/browser/notification_details.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_types.h"
+#include "content/public/browser/web_contents.h"
namespace extensions {
class Extension;
@@ -136,6 +137,17 @@ class ExtensionBrowserTest
// crashed.
bool WaitForExtensionCrash(const std::string& extension_id);
+ // Simulates a page calling window.open on an URL and waits for the
+ // navigation.
+ void OpenWindow(content::WebContents* contents,
+ const GURL& url,
+ bool newtab_process_should_equal_opener,
+ content::WebContents** newtab_result);
+
+ // Simulates a page navigating itself to an URL and waits for the
+ // navigation.
+ void NavigateInRenderer(content::WebContents* contents, const GURL& url);
+
// content::NotificationObserver
virtual void Observe(int type,
const content::NotificationSource& source,

Powered by Google App Engine
This is Rietveld 408576698