Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 10412045: Add java exception information to BuildInfo. (Closed)

Created:
8 years, 7 months ago by nilesh
Modified:
8 years, 7 months ago
Reviewers:
Yaron, Jay Civelli
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Add java exception information to BuildInfo. This information will be read by breakpad during minidump preparation to upload any java stack trace. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138435

Patch Set 1 #

Total comments: 2

Patch Set 2 : Jay's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -2 lines) Patch
M base/android/build_info.h View 1 3 chunks +10 lines, -0 lines 0 comments Download
M base/android/build_info.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M base/android/jni_android.cc View 3 chunks +64 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nilesh
8 years, 7 months ago (2012-05-22 22:08:34 UTC) #1
Jay Civelli
lgtm http://codereview.chromium.org/10412045/diff/1/base/android/build_info.h File base/android/build_info.h (right): http://codereview.chromium.org/10412045/diff/1/base/android/build_info.h#newcode70 base/android/build_info.h:70: void set_java_exception_info(std::string info); const std::string&
8 years, 7 months ago (2012-05-22 22:14:28 UTC) #2
Yaron
lgtm
8 years, 7 months ago (2012-05-22 22:23:40 UTC) #3
nilesh
http://codereview.chromium.org/10412045/diff/1/base/android/build_info.h File base/android/build_info.h (right): http://codereview.chromium.org/10412045/diff/1/base/android/build_info.h#newcode70 base/android/build_info.h:70: void set_java_exception_info(std::string info); On 2012/05/22 22:14:28, Jay Civelli wrote: ...
8 years, 7 months ago (2012-05-22 22:36:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/10412045/6001
8 years, 7 months ago (2012-05-22 22:48:55 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-23 05:59:51 UTC) #6
Change committed as 138435

Powered by Google App Engine
This is Rietveld 408576698