Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: base/android/build_info.h

Issue 10412045: Add java exception information to BuildInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Jay's comment Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/android/build_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/build_info.h
diff --git a/base/android/build_info.h b/base/android/build_info.h
index 95a0cf543694113047e9e926ad822dfcdccedf32..b08c7b7ca7b4f1836eba3b066f2a1cc5775df16a 100644
--- a/base/android/build_info.h
+++ b/base/android/build_info.h
@@ -17,6 +17,9 @@ namespace android {
// BuildInfo is a singleton class that stores android build and device
// information. It will be called from Android specific java code and gets used
// primarily in crash reporting.
+
+// It is also used to store the last java exception seen during JNI.
+// TODO(nileshagrawal): Find a better place to store this info.
class BuildInfo {
public:
@@ -60,6 +63,12 @@ class BuildInfo {
return package_version_name_;
}
+ const char* java_exception_info() const {
+ return java_exception_info_;
+ }
+
+ void set_java_exception_info(const std::string& info);
+
private:
BuildInfo();
@@ -76,6 +85,7 @@ class BuildInfo {
char* android_build_fp_;
char* package_version_code_;
char* package_version_name_;
+ char* java_exception_info_;
DISALLOW_COPY_AND_ASSIGN(BuildInfo);
};
« no previous file with comments | « no previous file | base/android/build_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698