Issue 10412021: Make socket send and receive more robust and return 0 on failure.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10412021: Make socket send and receive more robust and return 0 on failure. (Closed)

Created:
8 years, 7 months ago by Yang

Modified:
8 years, 7 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make socket send and receive more robust and return 0 on failure. R=jkummerow@chromium.org BUG=15719 TEST= Committed: https://code.google.com/p/v8/source/detail?r=11601

Patch Set 1 #

Total comments: 1

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -8 lines)			Patch
M	src/debug-agent.cc	View	2 chunks	+2 lines, -2 lines	1 comment	Download
M	src/platform.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	src/platform-posix.cc	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

8 years, 7 months ago (2012-05-21 09:56:13 UTC) #2

LGTM

http://codereview.chromium.org/10412021/diff/1/src/debug-agent.cc
File src/debug-agent.cc (right):

http://codereview.chromium.org/10412021/diff/1/src/debug-agent.cc#newcode1
src/debug-agent.cc:1: // Copyright 2009 the V8 project authors. All rights
reserved.
nit: 2012 :-)

Expand Messages | Collapse Messages