Make socket send and receive more robust and return 0 on failure.

src/debug-agent.cc

 // Copyright 2009 the V8 project authors. All rights reserved.

[Jakob Kummerow, 2012/05/21 09:56:13]

nit: 2012 :-)

 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
@@ skipping 228 matching lines @@
     const int kHeaderBufferSize = 80;
     char header_buffer[kHeaderBufferSize];
     int header_buffer_position = 0;
     char c = '\0';  // One character receive buffer.
     char prev_c = '\0';  // Previous character.
 
     // Read until CRLF.
     while (!(c == '\n' && prev_c == '\r')) {
       prev_c = c;
       received = conn->Receive(&c, 1);
-      if (received <= 0) {
+      if (received == 0) {
         PrintF("Error %d\n", Socket::LastError());
         return SmartArrayPointer<char>();
       }
 
       // Add character to header buffer.
       if (header_buffer_position < kHeaderBufferSize) {
         header_buffer[header_buffer_position++] = c;
       }
     }
 
@@ skipping 186 matching lines @@
 
   return true;
 }
 
 
 // Receive the full buffer before returning unless an error occours.
 int DebuggerAgentUtil::ReceiveAll(const Socket* conn, char* data, int len) {
   int total_received = 0;
   while (total_received < len) {
     int received = conn->Receive(data + total_received, len - total_received);
-    if (received <= 0) {
+    if (received == 0) {
       return total_received;
     }
     total_received += received;
   }
   return total_received;
 }
 
 } }  // namespace v8::internal
 
 #endif  // ENABLE_DEBUGGER_SUPPORT