Issue 10411075: net: add certificate pins for tor2web.org

Issue 10411075: net: add certificate pins for tor2web.org (Closed)

Created:
8 years, 7 months ago by agl

Modified:
8 years, 3 months ago

Reviewers:
palmer

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

net: add certificate pins for tor2web.org BUG=none TEST=none

Patch Set 1 #

Total comments: 4

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+149 lines, -1 line)			Patch
M	net/base/transport_security_state.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
	net/base/transport_security_state_static.h	View	3 chunks	+74 lines, -0 lines	2 comments	Download
	net/base/transport_security_state_static.certs	View	1 chunk	+56 lines, -0 lines	0 comments	Download
	net/base/transport_security_state_static.json	View	2 chunks	+8 lines, -0 lines	0 comments	Download
	net/base/transport_security_state_static_generate.go	View	1 chunk	+9 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

palmer

lgtm https://chromiumcodereview.appspot.com/10411075/diff/1/net/base/transport_security_state_static.h File net/base/transport_security_state_static.h (right): https://chromiumcodereview.appspot.com/10411075/diff/1/net/base/transport_security_state_static.h#newcode1557 net/base/transport_security_state_static.h:1557: {24, false, "\022emailprivacytester\003com", true, kNoPins, DOMAIN_NOT_PINNED }, Just ...

8 years, 7 months ago (2012-05-22 19:24:46 UTC) #2

agl

8 years, 7 months ago (2012-05-23 19:29:25 UTC) #3

https://chromiumcodereview.appspot.com/10411075/diff/1/net/base/transport_sec...
File net/base/transport_security_state_static.h (right):

https://chromiumcodereview.appspot.com/10411075/diff/1/net/base/transport_sec...
net/base/transport_security_state_static.h:1557: {24, false,
"\022emailprivacytester\003com", true, kNoPins, DOMAIN_NOT_PINNED },
On 2012/05/22 19:24:46, Chris P. wrote:
> Just want to make sure you intend to add http://emailprivacytester.com in this
CL also.

Yes, that's picking up a previous change to the JSON. Thanks.

https://chromiumcodereview.appspot.com/10411075/diff/1/net/base/transport_sec...
File net/base/transport_security_state_static_generate.go (right):

https://chromiumcodereview.appspot.com/10411075/diff/1/net/base/transport_sec...
net/base/transport_security_state_static_generate.go:295: if len(firstWord) == 0
{
On 2012/05/22 19:24:46, Chris P. wrote:
> Looks like inconsistent whitespace here.

That's just how codereview is showing it. I've run it through gofmt just to be
sure.

Expand Messages | Collapse Messages