Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10411033: Browser Plugin: WebContents should notify when it's restored (Closed)

Created:
8 years, 7 months ago by Fady Samuel
Modified:
8 years, 7 months ago
Reviewers:
jam, sky
CC:
chromium-reviews, asanka, jochen+watch-content_chromium.org, dhollowa+watch_chromium.org, jam, Randy Smith (Not in Mondays), joi+watch-content_chromium.org, darin-cc_chromium.org, dyu1, Ilya Sherman, Charlie Reis
Visibility:
Public.

Description

Browser Plugin: WebContnets should notify when it's restored Renamed NOTIFICATION_WEB_CONTENTS_HIDDEN to NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED and updated all appropriate places. We check for the detail false if we meant to check if the WebContents is hidden. This matches the behavior of RenderWidget's NOTIFICATION_RENDER_WIDGET_VISIBILITY_CHANGED. Added a WasRestored method to WebContents public interface. Call WasRestored from WebContents::ShowContents BUG=128814 TEST=did not break existing autofill popup browser test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138372

Patch Set 1 #

Patch Set 2 : Removed a test DCHECK #

Total comments: 6

Patch Set 3 : Fixed according to jam@ #

Patch Set 4 : Fixed typo in download_started_animation_mac.mm #

Patch Set 5 : Fixed broken win build #

Patch Set 6 : Another build fix #

Patch Set 7 : Merged with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -15 lines) Patch
M chrome/browser/autofill/autofill_popup_view.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/autofill/autofill_popup_view_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/download/download_started_animation_mac.mm View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_started_animation_gtk.cc View 4 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/download/download_started_animation_views.cc View 1 2 3 4 5 3 chunks +7 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 3 chunks +13 lines, -2 lines 0 comments Download
M content/public/browser/notification_types.h View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M content/public/browser/web_contents.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
Fady Samuel
8 years, 7 months ago (2012-05-18 23:00:19 UTC) #1
jam
lgtm http://codereview.chromium.org/10411033/diff/2001/chrome/browser/autofill/autofill_popup_view.cc File chrome/browser/autofill/autofill_popup_view.cc (right): http://codereview.chromium.org/10411033/diff/2001/chrome/browser/autofill/autofill_popup_view.cc#newcode202 chrome/browser/autofill/autofill_popup_view.cc:202: if (!visible || type == content::NOTIFICATION_NAV_ENTRY_COMMITTED) nit: this ...
8 years, 7 months ago (2012-05-18 23:40:50 UTC) #2
Fady Samuel
Fixed all thanks. Committing now. http://codereview.chromium.org/10411033/diff/2001/chrome/browser/autofill/autofill_popup_view.cc File chrome/browser/autofill/autofill_popup_view.cc (right): http://codereview.chromium.org/10411033/diff/2001/chrome/browser/autofill/autofill_popup_view.cc#newcode202 chrome/browser/autofill/autofill_popup_view.cc:202: if (!visible || type ...
8 years, 7 months ago (2012-05-19 15:59:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10411033/12
8 years, 7 months ago (2012-05-19 15:59:52 UTC) #4
commit-bot: I haz the power
Presubmit check for 10411033-12 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-19 16:00:01 UTC) #5
Fady Samuel
+sky for chrome/browser/ui/ OWNER
8 years, 7 months ago (2012-05-19 16:05:33 UTC) #6
sky
LGTM
8 years, 7 months ago (2012-05-21 14:42:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10411033/12
8 years, 7 months ago (2012-05-21 14:42:54 UTC) #8
commit-bot: I haz the power
Try job failure for 10411033-12 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-21 15:05:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10411033/10002
8 years, 7 months ago (2012-05-21 15:12:42 UTC) #10
commit-bot: I haz the power
Try job failure for 10411033-10002 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-21 15:35:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10411033/10005
8 years, 7 months ago (2012-05-21 15:49:53 UTC) #12
commit-bot: I haz the power
Try job failure for 10411033-10005 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-21 16:14:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10411033/13003
8 years, 7 months ago (2012-05-21 16:26:56 UTC) #14
commit-bot: I haz the power
Try job failure for 10411033-13003 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 7 months ago (2012-05-21 20:30:38 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10411033/13003
8 years, 7 months ago (2012-05-21 20:35:41 UTC) #16
commit-bot: I haz the power
Try job failure for 10411033-13003 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 7 months ago (2012-05-22 01:15:06 UTC) #17
commit-bot: I haz the power
Failed to apply the patch.
8 years, 7 months ago (2012-05-22 11:23:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10411033/4026
8 years, 7 months ago (2012-05-22 14:01:51 UTC) #19
commit-bot: I haz the power
Try job failure for 10411033-4026 (retry) (retry) on win_rel for step "compile" (clobber build). It's ...
8 years, 7 months ago (2012-05-22 17:25:42 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10411033/4026
8 years, 7 months ago (2012-05-22 18:28:15 UTC) #21
commit-bot: I haz the power
Try job failure for 10411033-4026 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 20:43:31 UTC) #22
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 21:05:14 UTC) #23

Powered by Google App Engine
This is Rietveld 408576698