Browser Plugin: WebContents should notify when it's restored

chrome/browser/ui/views/download/download_started_animation_views.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/download/download_started_animation.h"
 
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_source.h"
@@ skipping 78 matching lines @@
   }
 
   // If we're too small to show the download image, then don't bother -
   // the shelf will be enough.
   web_contents_->GetContainerBounds(&web_contents_bounds_);
   if (web_contents_bounds_.height() < kDownloadImage->height())
     return;
 
   registrar_.Add(
       this,
-      content::NOTIFICATION_WEB_CONTENTS_HIDDEN,
+      content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED,
       content::Source<WebContents>(web_contents_));
   registrar_.Add(
       this,
       content::NOTIFICATION_WEB_CONTENTS_DESTROYED,
       content::Source<WebContents>(web_contents_));
 
   SetImage(kDownloadImage);
 
   popup_ = new views::Widget;
 
@@ skipping 26 matching lines @@
       size.width(),
       size.height()));
 }
 
 void DownloadStartedAnimationWin::Close() {
   if (!web_contents_)
     return;
 
   registrar_.Remove(
       this,
-      content::NOTIFICATION_WEB_CONTENTS_HIDDEN,
+      content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED,
       content::Source<WebContents>(web_contents_));
   registrar_.Remove(
       this,
       content::NOTIFICATION_WEB_CONTENTS_DESTROYED,
       content::Source<WebContents>(web_contents_));
   web_contents_ = NULL;
   popup_->Close();
 }
 
 void DownloadStartedAnimationWin::AnimateToState(double state) {
   if (state >= 1.0) {
     Close();
   } else {
     Reposition();
 
     // Start at zero, peak halfway and end at zero.
     double opacity = std::min(1.0 - pow(GetCurrentValue() - 0.5, 2) * 4.0,
                               static_cast<double>(1.0));
 
     popup_->SetOpacity(static_cast<unsigned char>(opacity * 255.0));
   }
 }
 
 void DownloadStartedAnimationWin::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
+  if (type == content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED) {
+    bool visible = *content::Details<bool>(details).ptr();
+    if (visible)
+      return;
+  }
   Close();
 }
 
 }  // namespace
 
 // static
 void DownloadStartedAnimation::Show(WebContents* web_contents) {
   // The animation will delete itself when it's finished or when the tab
   // contents is hidden or destroyed.
   new DownloadStartedAnimationWin(web_contents);
 }