Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 10411012: Add an Afrikaans dictionary and a Faroese one. (Closed)

Created:
8 years, 7 months ago by Hironori Bono
Modified:
8 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews
Visibility:
Public.

Description

Add an Afrikaans dictionary and a Faroese one. This change adds a couple of spellchecker dictionaries (Afrikaans and Faroese). TBR=jshin BUG=82125, 124599 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138760

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12026 lines, -0 lines) Patch
A third_party/hunspell_dictionaries/af-ZA-2-3.bdic View 1 Binary file 0 comments Download
A third_party/hunspell_dictionaries/af_ZA/README.chromium View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/hunspell_dictionaries/af_ZA/README-af-ZA.txt View 1 1 chunk +673 lines, -0 lines 0 comments Download
A third_party/hunspell_dictionaries/af_ZA/af-ZA.aff View 1 1 chunk +209 lines, -0 lines 0 comments Download
A third_party/hunspell_dictionaries/fo-FO-2-3.bdic View 1 Binary file 0 comments Download
A third_party/hunspell_dictionaries/fo_FO/LICENSE_en_US.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/hunspell_dictionaries/fo_FO/README.chromium View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/hunspell_dictionaries/fo_FO/fo_FO.aff View 1 1 chunk +11118 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Hironori Bono
8 years, 7 months ago (2012-05-21 10:37:32 UTC) #1
jungshik at Google
Thank you for adding these two. Could you address my comments? http://codereview.chromium.org/10411012/diff/1/third_party/hunspell_dictionaries/af_ZA/README.chromium File third_party/hunspell_dictionaries/af_ZA/README.chromium (right): ...
8 years, 7 months ago (2012-05-21 17:59:13 UTC) #2
Hironori Bono
8 years, 7 months ago (2012-05-23 00:21:33 UTC) #3
Greetings Jungshik,

Thanks for your comments. I have updated the README files to apply them.

Regards,

Hironori Bono

http://codereview.chromium.org/10411012/diff/1/third_party/hunspell_dictionar...
File third_party/hunspell_dictionaries/af_ZA/README.chromium (right):

http://codereview.chromium.org/10411012/diff/1/third_party/hunspell_dictionar...
third_party/hunspell_dictionaries/af_ZA/README.chromium:7: This folder contains
a partial copy of the Afrikaans dictionary for hunspell.
On 2012/05/21 17:59:13, Jungshik Shin wrote:
> Could you be more specific about 'a partial copy'?  That is, what's different
> between our copy and the original? 
> It'd be nice if the same information is in the CL description. 

Done. Thanks for noticing it. This change does not include installation scripts
for Firefox included in the original archive.

http://codereview.chromium.org/10411012/diff/1/third_party/hunspell_dictionar...
File third_party/hunspell_dictionaries/fo_FO/README.chromium (right):

http://codereview.chromium.org/10411012/diff/1/third_party/hunspell_dictionar...
third_party/hunspell_dictionaries/fo_FO/README.chromium:7: This folder contains
a partial copy of the Faroese dictionary for hunspell.
On 2012/05/21 17:59:13, Jungshik Shin wrote:
> Same here...

Done. Same as Afrikaans, this dictionary also includes installation scripts for
Firefox and this change removed them.

Powered by Google App Engine
This is Rietveld 408576698