Issue 10409065: Change setters of dbus::Message to return false instead of aborting on errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10409065: Change setters of dbus::Message to return false instead of aborting on errors (Closed)

Created:
8 years, 7 months ago by hashimoto

Modified:
8 years, 7 months ago

Reviewers:
satorux1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Change setters of dbus::Message to return false instead of aborting on errors With this change, we can safely return error for invalid object path and service name. It still crashes on invalid method name and interface name if we use MethodCall::MethodCall for setting those parameters. BUG=128967 TEST=dbus_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138441

Patch Set 1 : _ #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+148 lines, -47 lines)			Patch
M	dbus/end_to_end_async_unittest.cc	View	1 chunk	+38 lines, -0 lines	0 comments	Download
M	dbus/end_to_end_sync_unittest.cc	View	1 chunk	+32 lines, -0 lines	0 comments	Download
M	dbus/exported_object.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dbus/message.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	dbus/message.cc	View	3 chunks	+16 lines, -28 lines	0 comments	Download
M	dbus/message_unittest.cc	View	2 chunks	+36 lines, -6 lines	0 comments	Download
M	dbus/object_proxy.cc	View	2 chunks	+19 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

8 years, 7 months ago (2012-05-23 00:34:54 UTC) #3

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10409065/2001

Expand Messages | Collapse Messages