Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2079)

Unified Diff: dbus/message.cc

Issue 10409065: Change setters of dbus::Message to return false instead of aborting on errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: _ Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dbus/message.h ('k') | dbus/message_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dbus/message.cc
diff --git a/dbus/message.cc b/dbus/message.cc
index 400c1bcfd2a8e9bdfc083451757e8acad1b7d2b4..5b45d423908054ca051302b5012262875ae9635d 100644
--- a/dbus/message.cc
+++ b/dbus/message.cc
@@ -249,40 +249,28 @@ std::string Message::ToString() {
return headers + "\n" + ToStringInternal("", &reader);
}
-void Message::SetDestination(const std::string& destination) {
- const bool success = dbus_message_set_destination(raw_message_,
- destination.c_str());
- CHECK(success) << "Unable to allocate memory";
+bool Message::SetDestination(const std::string& destination) {
+ return dbus_message_set_destination(raw_message_, destination.c_str());
}
-void Message::SetPath(const ObjectPath& path) {
- const bool success = dbus_message_set_path(raw_message_,
- path.value().c_str());
- CHECK(success) << "Unable to allocate memory";
+bool Message::SetPath(const ObjectPath& path) {
+ return dbus_message_set_path(raw_message_, path.value().c_str());
}
-void Message::SetInterface(const std::string& interface) {
- const bool success = dbus_message_set_interface(raw_message_,
- interface.c_str());
- CHECK(success) << "Unable to allocate memory";
+bool Message::SetInterface(const std::string& interface) {
+ return dbus_message_set_interface(raw_message_, interface.c_str());
}
-void Message::SetMember(const std::string& member) {
- const bool success = dbus_message_set_member(raw_message_,
- member.c_str());
- CHECK(success) << "Unable to allocate memory";
+bool Message::SetMember(const std::string& member) {
+ return dbus_message_set_member(raw_message_, member.c_str());
}
-void Message::SetErrorName(const std::string& error_name) {
- const bool success = dbus_message_set_error_name(raw_message_,
- error_name.c_str());
- CHECK(success) << "Unable to allocate memory";
+bool Message::SetErrorName(const std::string& error_name) {
+ return dbus_message_set_error_name(raw_message_, error_name.c_str());
}
-void Message::SetSender(const std::string& sender) {
- const bool success = dbus_message_set_sender(raw_message_,
- sender.c_str());
- CHECK(success) << "Unable to allocate memory";
+bool Message::SetSender(const std::string& sender) {
+ return dbus_message_set_sender(raw_message_, sender.c_str());
}
void Message::SetSerial(uint32 serial) {
@@ -345,8 +333,8 @@ MethodCall::MethodCall(const std::string& interface_name,
: Message() {
Init(dbus_message_new(DBUS_MESSAGE_TYPE_METHOD_CALL));
- SetInterface(interface_name);
- SetMember(method_name);
+ CHECK(SetInterface(interface_name));
+ CHECK(SetMember(method_name));
}
MethodCall::MethodCall() : Message() {
@@ -368,8 +356,8 @@ Signal::Signal(const std::string& interface_name,
: Message() {
Init(dbus_message_new(DBUS_MESSAGE_TYPE_SIGNAL));
- SetInterface(interface_name);
- SetMember(method_name);
+ CHECK(SetInterface(interface_name));
+ CHECK(SetMember(method_name));
}
Signal::Signal() : Message() {
« no previous file with comments | « dbus/message.h ('k') | dbus/message_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698