validate CHROME_SRC setting to avoid confusion

validate CHROME_SRC setting to avoid confusion


BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=139480

[Wei James(wistoch), 2012-05-21 07:10:24]

the motivation of this patch is that:

I have two chromium working repo tree and always switch between them. When I was
doing this, I got some strange error information and at last I found the root
cause is that CHROME_SRC is incorrect(set in one working tree and be kept in
another tree). 

So I think it will be better if there is some warning information if we detect
that the current working directory is out of CHROME_SRC. 

thanks

[John Grabowski, 2012-05-25 02:19:28]

https://chromiumcodereview.appspot.com/10409048/diff/1/build/android/envsetup.sh
File build/android/envsetup.sh (right):

https://chromiumcodereview.appspot.com/10409048/diff/1/build/android/envsetup...
build/android/envsetup.sh:94: PWD=$(readlink -f .)
The shell sets $PWD so I don't think you want to override it.
(Can't you just reference it without setting it?)

https://chromiumcodereview.appspot.com/10409048/diff/1/build/android/envsetup...
build/android/envsetup.sh:101: if [ "${PWD/"${CHROME_SRC}"/}" == "${PWD}" ];
then
Add comment explaining motivation

[Wei James(wistoch), 2012-05-25 02:53:24]

http://chromiumcodereview.appspot.com/10409048/diff/1/build/android/envsetup.sh
File build/android/envsetup.sh (right):

http://chromiumcodereview.appspot.com/10409048/diff/1/build/android/envsetup....
build/android/envsetup.sh:94: PWD=$(readlink -f .)
On 2012/05/25 02:19:28, John Grabowski wrote:
> The shell sets $PWD so I don't think you want to override it.
> (Can't you just reference it without setting it?)
yes. fixed. thanks

http://chromiumcodereview.appspot.com/10409048/diff/1/build/android/envsetup....
build/android/envsetup.sh:101: if [ "${PWD/"${CHROME_SRC}"/}" == "${PWD}" ];
then
On 2012/05/25 02:19:28, John Grabowski wrote:
> Add comment explaining motivation

fixed. thanks

[John Grabowski, 2012-05-25 16:27:18]

http://chromiumcodereview.appspot.com/10409048/diff/4001/build/android/envset...
File build/android/envsetup.sh (right):

http://chromiumcodereview.appspot.com/10409048/diff/4001/build/android/envset...
build/android/envsetup.sh:99: if [ "${PWD/"${CHROME_SRC}"/}" == "${PWD}" ]; then
Sorry I didn't mention this the first time, but...
I'm not sure I understand this syntax?
What is "${PWD/"${CHROME_SRC}"/}" supposed to do?
I think it'll equal "" always since this would resolve to ${PWD//homedir/src/},
and you can't have a / in a variable name.

[Wei James(wistoch), 2012-05-26 05:01:47]

http://chromiumcodereview.appspot.com/10409048/diff/4001/build/android/envset...
File build/android/envsetup.sh (right):

http://chromiumcodereview.appspot.com/10409048/diff/4001/build/android/envset...
build/android/envsetup.sh:99: if [ "${PWD/"${CHROME_SRC}"/}" == "${PWD}" ]; then
On 2012/05/25 16:27:19, John Grabowski wrote:
> Sorry I didn't mention this the first time, but...
> I'm not sure I understand this syntax?
> What is "${PWD/"${CHROME_SRC}"/}" supposed to do?
> I think it'll equal "" always since this would resolve to
${PWD//homedir/src/},
> and you can't have a / in a variable name.
> 
if we are in the correct directory and CHROME_SRC is set correctly, it will
equal to "". but if not, it will not. 

for example, on my box: 

$echo $CHROME_SRC
/home/wistoch/workspace/chromium-android/src
$echo $PWD
/home/wistoch/workspace/chromium-android/src
$echo ${PWD/$CHROME_SRC/}
it is equal to "". 

in case it is not correct: 
$export CHROME_SRC=/home/wistoch/workspace/chromium-android-x86/src
$ echo ${PWD/$CHROME_SRC/}
/home/wistoch/workspace/chromium-android/src

so ${PWD/$CHROME_SRC/} equal to ${PWD}, so we know something is wrong.

[John Grabowski, 2012-05-29 17:50:23]

LGTM

http://chromiumcodereview.appspot.com/10409048/diff/4001/build/android/envset...
File build/android/envsetup.sh (right):

http://chromiumcodereview.appspot.com/10409048/diff/4001/build/android/envset...
build/android/envsetup.sh:99: if [ "${PWD/"${CHROME_SRC}"/}" == "${PWD}" ]; then
On 2012/05/26 05:01:47, James Wei wrote:
> On 2012/05/25 16:27:19, John Grabowski wrote:
> > Sorry I didn't mention this the first time, but...
> > I'm not sure I understand this syntax?
> > What is "${PWD/"${CHROME_SRC}"/}" supposed to do?
> > I think it'll equal "" always since this would resolve to
> ${PWD//homedir/src/},
> > and you can't have a / in a variable name.
> > 
> if we are in the correct directory and CHROME_SRC is set correctly, it will
> equal to "". but if not, it will not. 
> 
> for example, on my box: 
> 
> $echo $CHROME_SRC
> /home/wistoch/workspace/chromium-android/src
> $echo $PWD
> /home/wistoch/workspace/chromium-android/src
> $echo ${PWD/$CHROME_SRC/}
> it is equal to "". 
> 
> in case it is not correct: 
> $export CHROME_SRC=/home/wistoch/workspace/chromium-android-x86/src
> $ echo ${PWD/$CHROME_SRC/}
> /home/wistoch/workspace/chromium-android/src
> 
> so ${PWD/$CHROME_SRC/} equal to ${PWD}, so we know something is wrong. 
> 

OK... it's a little cryptic.
Can you add this comment in the code?

[Wei James(wistoch), 2012-05-30 03:00:15]

http://chromiumcodereview.appspot.com/10409048/diff/4001/build/android/envset...
File build/android/envsetup.sh (right):

http://chromiumcodereview.appspot.com/10409048/diff/4001/build/android/envset...
build/android/envsetup.sh:99: if [ "${PWD/"${CHROME_SRC}"/}" == "${PWD}" ]; then
On 2012/05/29 17:50:23, John Grabowski wrote:
> On 2012/05/26 05:01:47, James Wei wrote:
> > On 2012/05/25 16:27:19, John Grabowski wrote:
> > > Sorry I didn't mention this the first time, but...
> > > I'm not sure I understand this syntax?
> > > What is "${PWD/"${CHROME_SRC}"/}" supposed to do?
> > > I think it'll equal "" always since this would resolve to
> > ${PWD//homedir/src/},
> > > and you can't have a / in a variable name.
> > > 
> > if we are in the correct directory and CHROME_SRC is set correctly, it will
> > equal to "". but if not, it will not. 
> > 
> > for example, on my box: 
> > 
> > $echo $CHROME_SRC
> > /home/wistoch/workspace/chromium-android/src
> > $echo $PWD
> > /home/wistoch/workspace/chromium-android/src
> > $echo ${PWD/$CHROME_SRC/}
> > it is equal to "". 
> > 
> > in case it is not correct: 
> > $export CHROME_SRC=/home/wistoch/workspace/chromium-android-x86/src
> > $ echo ${PWD/$CHROME_SRC/}
> > /home/wistoch/workspace/chromium-android/src
> > 
> > so ${PWD/$CHROME_SRC/} equal to ${PWD}, so we know something is wrong. 
> > 
> 
> OK... it's a little cryptic.
> Can you add this comment in the code?

fixed. thanks

[commit-bot: I haz the power, 2012-05-30 03:00:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/james.wei@intel.com/10409048/11001

[commit-bot: I haz the power, 2012-05-30 07:44:24]

Change committed as 139480