validate CHROME_SRC setting to avoid confusion

build/android/envsetup.sh

 #!/bin/bash
 
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Sets up environment for building Chromium on Android. Only Android NDK,
 # Revision 6b on Linux or Mac is offically supported.
 #
 # To run this script, the system environment ANDROID_NDK_ROOT must be set
@@ skipping 75 matching lines @@
 
 # Add Android SDK/NDK tools to system path.
 export PATH=$PATH:${ANDROID_NDK_ROOT}
 export PATH=$PATH:${ANDROID_SDK_ROOT}/tools
 export PATH=$PATH:${ANDROID_SDK_ROOT}/platform-tools
 # Must have tools like arm-linux-androideabi-gcc on the path for ninja
 export PATH=$PATH:${ANDROID_TOOLCHAIN}
 
 if [ -z "${CHROME_SRC}" ]; then
   # If $CHROME_SRC was not set, assume current directory is CHROME_SRC.
-  export CHROME_SRC=$(readlink -f .)
+  export CHROME_SRC="${PWD}"
+fi
+
+if [ "${PWD/"${CHROME_SRC}"/}" == "${PWD}" ]; then

[John Grabowski, 2012/05/25 16:27:19]

Sorry I didn't mention this the first time, but...
I'm not sure I understand this syntax?
What is "${PWD/"${CHROME_SRC}"/}" supposed to do?
I think it'll equal "" always since this would resolve to ${PWD//homedir/src/},
and you can't have a / in a variable name.

[Wei James(wistoch), 2012/05/26 05:01:47]

if we are in the correct directory and CHROME_SRC is set correctly, it will
equal to "". but if not, it will not. 

for example, on my box: 

$echo $CHROME_SRC
/home/wistoch/workspace/chromium-android/src
$echo $PWD
/home/wistoch/workspace/chromium-android/src
$echo ${PWD/$CHROME_SRC/}
it is equal to "". 

in case it is not correct: 
$export CHROME_SRC=/home/wistoch/workspace/chromium-android-x86/src
$ echo ${PWD/$CHROME_SRC/}
/home/wistoch/workspace/chromium-android/src

so ${PWD/$CHROME_SRC/} equal to ${PWD}, so we know something is wrong. 

[John Grabowski, 2012/05/29 17:50:23]

OK... it's a little cryptic.
Can you add this comment in the code?

[Wei James(wistoch), 2012/05/30 03:00:15]

fixed. thanks

+  # If current directory is not in $CHROME_SRC, it might be set for other
+  # source tree.
+  echo "Warning: Current directory is out of CHROME_SRC, it may not be \
+the one you want."
+  echo "${CHROME_SRC}"
 fi
 
 if [ ! -d "${CHROME_SRC}" ]; then
   echo "CHROME_SRC must be set to the path of Chrome source code." >& 2
   return 1
 fi
 
 # Add Chromium Android development scripts to system path.
 # Must be after CHROME_SRC is set.
 export PATH=$PATH:${CHROME_SRC}/build/android
@@ skipping 37 matching lines @@
 export GYP_DEFINES="${DEFINES}"
 
 # Use the "android" flavor of the Makefile generator for both Linux and OS X.
 export GYP_GENERATORS="make-android"
 
 # Use our All target as the default
 export GYP_GENERATOR_FLAGS="${GYP_GENERATOR_FLAGS} default_target=All"
 
 # We want to use our version of "all" targets.
 export CHROMIUM_GYP_FILE="${CHROME_SRC}/build/all_android.gyp"