Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10409046: Migrate the rest of the "global" prefs. (Closed)

Created:
8 years, 7 months ago by falken
Modified:
8 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, Nirnimesh, Raghu Simha, ajwong+watch_chromium.org, kkania, ncarter (slow), dennis_jeffrey, Aaron Boodman, arv (Not doing code reviews), robertshield, tim (not reviewing), dyu1, brettw-cc_chromium.org, Avi (use Gerrit), darin-cc_chromium.org, anantha, jshin+watch_chromium.org
Visibility:
Public.

Description

Migrate the rest of the "global" prefs. This is a continuation of the work in r137835. TBR=gene for cloud print, mpcomplete for extension BUG=123812 TEST=browser_tests --gtest_filter=PrefsTab* and ExtensionApiTest.Font* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138219

Patch Set 1 #

Patch Set 2 : style fixes #

Total comments: 11

Patch Set 3 : sync #

Patch Set 4 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+194 lines, -189 lines) Patch
M chrome/browser/automation/automation_provider.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/browser_encoding_browsertest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 3 chunks +11 lines, -13 lines 0 comments Download
M chrome/browser/extensions/extension_font_settings_api.cc View 9 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/extensions/extension_font_settings_apitest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/net/chrome_url_request_context.cc View 1 2 3 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/prefs/overlay_user_pref_store_unittest.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/prefs/pref_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/options2/font_settings.html View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/two_client_preferences_sync_test.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 10 chunks +47 lines, -51 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper_browsertest.cc View 3 chunks +40 lines, -26 lines 0 comments Download
M chrome/browser/ui/toolbar/encoding_menu_controller.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/options2/browser_options_handler2.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options2/font_settings_handler2.cc View 2 chunks +8 lines, -12 lines 0 comments Download
M chrome/common/pref_names.h View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/pref_names.cc View 1 5 chunks +20 lines, -19 lines 0 comments Download
M chrome/test/data/profiles/webkit_global_reverse_migration/Default/Preferences View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/test/functional/prefs.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
falken
This patch is mostly mechanical changes, finishing the renaming of the obsolete global prefs back ...
8 years, 7 months ago (2012-05-21 11:05:45 UTC) #1
battre
LGTM for chrome/browser/prefs, chrome/browser/net
8 years, 7 months ago (2012-05-21 12:13:55 UTC) #2
willchan no longer on Chromium
LGTM
8 years, 7 months ago (2012-05-21 18:20:50 UTC) #3
Nirnimesh
chrome/test/functional LGTM
8 years, 7 months ago (2012-05-21 18:45:46 UTC) #4
akalin
On 2012/05/21 18:45:46, Nirnimesh wrote: > chrome/test/functional LGTM sync lgtm
8 years, 7 months ago (2012-05-21 19:43:46 UTC) #5
Evan Stade
options2 lgtm
8 years, 7 months ago (2012-05-21 20:57:07 UTC) #6
Peter Kasting
LGTM https://chromiumcodereview.appspot.com/10409046/diff/2001/chrome/browser/browser_encoding_browsertest.cc File chrome/browser/browser_encoding_browsertest.cc (right): https://chromiumcodereview.appspot.com/10409046/diff/2001/chrome/browser/browser_encoding_browsertest.cc#newcode259 chrome/browser/browser_encoding_browsertest.cc:259: prefs::kDefaultCharset, "ISO-8859-4"); Nit: Slightly easier to read: browser()->profile()->GetPrefs()->SetString(prefs::kDefaultCharset, ...
8 years, 7 months ago (2012-05-21 21:37:20 UTC) #7
falken
Thanks for the reviews! https://chromiumcodereview.appspot.com/10409046/diff/2001/chrome/browser/browser_encoding_browsertest.cc File chrome/browser/browser_encoding_browsertest.cc (right): https://chromiumcodereview.appspot.com/10409046/diff/2001/chrome/browser/browser_encoding_browsertest.cc#newcode259 chrome/browser/browser_encoding_browsertest.cc:259: prefs::kDefaultCharset, "ISO-8859-4"); On 2012/05/21 21:37:20, ...
8 years, 7 months ago (2012-05-22 02:24:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/10409046/12003
8 years, 7 months ago (2012-05-22 02:26:52 UTC) #9
commit-bot: I haz the power
Try job failure for 10409046-12003 (retry) on win_rel for steps "base_unittests, sync_unit_tests". It's a second ...
8 years, 7 months ago (2012-05-22 04:47:59 UTC) #10
Matt Perry
8 years, 7 months ago (2012-05-22 20:29:32 UTC) #11 
lgtm

Powered by Google App Engine
This is Rietveld 408576698