Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: chrome/browser/sync/profile_sync_service_preference_unittest.cc

Issue 10409046: Migrate the rest of the "global" prefs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <map> 5 #include <map>
6 #include <string> 6 #include <string>
7 7
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
307 url_list->Append(Value::CreateStringValue(example_url0_)); 307 url_list->Append(Value::CreateStringValue(example_url0_));
308 url_list->Append(Value::CreateStringValue(example_url1_)); 308 url_list->Append(Value::CreateStringValue(example_url1_));
309 } 309 }
310 310
311 PreferenceValues cloud_data; 311 PreferenceValues cloud_data;
312 cloud_data[prefs::kHomePage] = Value::CreateStringValue(example_url1_); 312 cloud_data[prefs::kHomePage] = Value::CreateStringValue(example_url1_);
313 ListValue* urls_to_restore = new ListValue; 313 ListValue* urls_to_restore = new ListValue;
314 urls_to_restore->Append(Value::CreateStringValue(example_url1_)); 314 urls_to_restore->Append(Value::CreateStringValue(example_url1_));
315 urls_to_restore->Append(Value::CreateStringValue(example_url2_)); 315 urls_to_restore->Append(Value::CreateStringValue(example_url2_));
316 cloud_data[prefs::kURLsToRestoreOnStartup] = urls_to_restore; 316 cloud_data[prefs::kURLsToRestoreOnStartup] = urls_to_restore;
317 cloud_data[prefs::kGlobalDefaultCharset] = 317 cloud_data[prefs::kDefaultCharset] =
318 Value::CreateStringValue(non_default_charset_value_); 318 Value::CreateStringValue(non_default_charset_value_);
319 319
320 AddPreferenceEntriesHelper helper(this, cloud_data); 320 AddPreferenceEntriesHelper helper(this, cloud_data);
321 ASSERT_TRUE(StartSyncService(helper.callback(), false)); 321 ASSERT_TRUE(StartSyncService(helper.callback(), false));
322 ASSERT_TRUE(helper.success()); 322 ASSERT_TRUE(helper.success());
323 323
324 scoped_ptr<const Value> value(GetSyncedValue(prefs::kHomePage)); 324 scoped_ptr<const Value> value(GetSyncedValue(prefs::kHomePage));
325 ASSERT_TRUE(value.get()); 325 ASSERT_TRUE(value.get());
326 std::string string_value; 326 std::string string_value;
327 EXPECT_TRUE(static_cast<const StringValue*>(value.get())-> 327 EXPECT_TRUE(static_cast<const StringValue*>(value.get())->
328 GetAsString(&string_value)); 328 GetAsString(&string_value));
329 EXPECT_EQ(example_url1_, string_value); 329 EXPECT_EQ(example_url1_, string_value);
330 EXPECT_EQ(example_url1_, prefs_->GetString(prefs::kHomePage)); 330 EXPECT_EQ(example_url1_, prefs_->GetString(prefs::kHomePage));
331 331
332 scoped_ptr<ListValue> expected_urls(new ListValue); 332 scoped_ptr<ListValue> expected_urls(new ListValue);
333 expected_urls->Append(Value::CreateStringValue(example_url1_)); 333 expected_urls->Append(Value::CreateStringValue(example_url1_));
334 expected_urls->Append(Value::CreateStringValue(example_url2_)); 334 expected_urls->Append(Value::CreateStringValue(example_url2_));
335 expected_urls->Append(Value::CreateStringValue(example_url0_)); 335 expected_urls->Append(Value::CreateStringValue(example_url0_));
336 value.reset(GetSyncedValue(prefs::kURLsToRestoreOnStartup)); 336 value.reset(GetSyncedValue(prefs::kURLsToRestoreOnStartup));
337 ASSERT_TRUE(value.get()); 337 ASSERT_TRUE(value.get());
338 EXPECT_TRUE(value->Equals(expected_urls.get())); 338 EXPECT_TRUE(value->Equals(expected_urls.get()));
339 EXPECT_TRUE(GetPreferenceValue(prefs::kURLsToRestoreOnStartup). 339 EXPECT_TRUE(GetPreferenceValue(prefs::kURLsToRestoreOnStartup).
340 Equals(expected_urls.get())); 340 Equals(expected_urls.get()));
341 341
342 value.reset(GetSyncedValue(prefs::kGlobalDefaultCharset)); 342 value.reset(GetSyncedValue(prefs::kDefaultCharset));
343 ASSERT_TRUE(value.get()); 343 ASSERT_TRUE(value.get());
344 EXPECT_TRUE(static_cast<const StringValue*>(value.get())-> 344 EXPECT_TRUE(static_cast<const StringValue*>(value.get())->
345 GetAsString(&string_value)); 345 GetAsString(&string_value));
346 EXPECT_EQ(non_default_charset_value_, string_value); 346 EXPECT_EQ(non_default_charset_value_, string_value);
347 EXPECT_EQ(non_default_charset_value_, 347 EXPECT_EQ(non_default_charset_value_,
348 prefs_->GetString(prefs::kGlobalDefaultCharset)); 348 prefs_->GetString(prefs::kDefaultCharset));
349 STLDeleteValues(&cloud_data); 349 STLDeleteValues(&cloud_data);
350 } 350 }
351 351
352 TEST_F(ProfileSyncServicePreferenceTest, FailModelAssociation) { 352 TEST_F(ProfileSyncServicePreferenceTest, FailModelAssociation) {
353 ASSERT_TRUE(StartSyncService(base::Closure(), true)); 353 ASSERT_TRUE(StartSyncService(base::Closure(), true));
354 EXPECT_TRUE(service_->unrecoverable_error_detected()); 354 EXPECT_TRUE(service_->unrecoverable_error_detected());
355 } 355 }
356 356
357 TEST_F(ProfileSyncServicePreferenceTest, UpdatedPreferenceWithDefaultValue) { 357 TEST_F(ProfileSyncServicePreferenceTest, UpdatedPreferenceWithDefaultValue) {
358 const PrefService::Preference* pref = 358 const PrefService::Preference* pref =
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
575 EXPECT_FALSE(pref->IsDefaultValue()); 575 EXPECT_FALSE(pref->IsDefaultValue());
576 // There should be no synced value. 576 // There should be no synced value.
577 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL); 577 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL);
578 // Switch kHomePage back to unmanaged. 578 // Switch kHomePage back to unmanaged.
579 profile_->GetTestingPrefService()->RemoveManagedPref(prefs::kHomePage); 579 profile_->GetTestingPrefService()->RemoveManagedPref(prefs::kHomePage);
580 // The original value should be picked up. 580 // The original value should be picked up.
581 EXPECT_TRUE(pref->IsDefaultValue()); 581 EXPECT_TRUE(pref->IsDefaultValue());
582 // There should still be no synced value. 582 // There should still be no synced value.
583 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL); 583 EXPECT_TRUE(GetSyncedValue(prefs::kHomePage) == NULL);
584 } 584 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698